Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow comments in input file #1346

Merged
merged 5 commits into from
Sep 11, 2024
Merged

allow comments in input file #1346

merged 5 commits into from
Sep 11, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1333 ( based on #1215)

@dogancanbakir dogancanbakir self-assigned this Aug 13, 2024
@dogancanbakir dogancanbakir mentioned this pull request Aug 13, 2024
Closed
Mzack9999
Mzack9999 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Two suggestions:

  • What about adding this functionality in utils as it appears that comments might be useful in multiple tools
  • If the previous point makes sense, we should cover the functionality with tests

@dogancanbakir dogancanbakir mentioned this pull request Aug 14, 2024
Closed
@ehsandeep ehsandeep merged commit bb127fb into dev Sep 11, 2024
8 checks passed
@ehsandeep ehsandeep deleted the allow_comments_in_input_file branch September 11, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow comments in domains file
3 participants
@dogancanbakir @ehsandeep @Mzack9999