Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support with_response on interaction callbacks #167

Merged
merged 11 commits into from
Oct 26, 2024

Conversation

TTtie
Copy link
Member

@TTtie TTtie commented Sep 25, 2024

Separated from #162 as this change is broader.

Adds support for the with_response parameter for the interaction callback. This is leveraged:

  • in interaction createMessage/editParent calls to return a fully-fledged Message object
  • in interaction launchActivity calls to return the callback response

Not so sure about including this parameter for other Interaction methods as the usefulness of the data is nearly zero as it is available in user code while performing the interaction.

Ref: discord/discord-api-docs@8bc883c

@TTtie TTtie added type: enhancement New feature or request scope: REST Issues or pull requests related to REST functionality reason: Discord Issues or pull requests related to Discord's API changes labels Sep 25, 2024
@TTtie TTtie added this to the 0.2.0 milestone Sep 25, 2024
@TTtie TTtie force-pushed the feat/interactions-with-response branch from b492198 to 9626977 Compare October 17, 2024 09:21
@TTtie TTtie marked this pull request as ready for review October 21, 2024 11:18
@TTtie TTtie merged commit 67c679f into dev Oct 26, 2024
1 check passed
@TTtie TTtie deleted the feat/interactions-with-response branch October 28, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reason: Discord Issues or pull requests related to Discord's API changes scope: REST Issues or pull requests related to REST functionality type: enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant