Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added port option to rest options #78

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Added port option to rest options #78

merged 2 commits into from
Jul 1, 2023

Conversation

nazmigorkem
Copy link
Contributor

Adding port in to the domain option does not work as intended since Node.js HTTP lib does not allow that. Thus, added port option.

@TTtie TTtie added scope: REST Issues or pull requests related to REST functionality type: enhancement New feature or request labels Jun 30, 2023
@TTtie TTtie added this to the 0.2.0 milestone Jun 30, 2023
@TTtie TTtie self-assigned this Jun 30, 2023
Copy link
Member

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, feel free to fine tune the description in lib/Client.js if you want to

@TTtie TTtie merged commit 510aeaa into projectdysnomia:dev Jul 1, 2023
2 checks passed
TTtie added a commit that referenced this pull request Jul 1, 2023
TTtie added a commit that referenced this pull request Jul 7, 2023
* added port option to rest options

* Add docs for the new option

---------

Co-authored-by: TTtie <[email protected]>
TTtie added a commit that referenced this pull request Aug 10, 2023
* added port option to rest options

* Add docs for the new option

---------

Co-authored-by: TTtie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: REST Issues or pull requests related to REST functionality type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants