refactor: don't call update() multiple times in the prototype chain #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update() method is already called in the base class - according to JS class semantics, when calling a constructor via `super`, `this` still points to the object at the top of the prototype chain, resulting in the update() method called twice or more.
TTtie
added
type: enhancement
TTtie
added a commit
that referenced
this pull request
Jul 27, 2023
) The update() method is already called in the base class - according to JS class semantics, when calling a constructor via `super`, `this` still points to the object at the top of the prototype chain, resulting in the update() method being called twice or more down the prototype chain as the super-classes initialize.
TTtie
added a commit
that referenced
this pull request
Aug 10, 2023
) The update() method is already called in the base class - according to JS class semantics, when calling a constructor via `super`, `this` still points to the object at the top of the prototype chain, resulting in the update() method being called twice or more down the prototype chain as the super-classes initialize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update() method is already called in the base class - according to JS class semantics, when calling a constructor via
super,thisstill points to the object at the top of the prototype chain, resulting in the update() method being called twice or more down the prototype chain as the super-classes initialize.