Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(OAuthApplicationInfo): remove guild property #95

Closed
wants to merge 1 commit into from

Conversation

TTtie
Copy link
Member

@TTtie TTtie commented Aug 3, 2023

Per the newly released OpenAPI spec (https://github.com/discord/discord-api-spec), there doesn't even seem to be one... (structure PrivateApplicationResponse)

It should be, however, noted, that the spec isn't considered the source of truth per the same repository.

@TTtie TTtie added the scope: typings Issues or pull requests related to TypeScript definitions label Aug 3, 2023
@TTtie TTtie added this to the 0.2.0 milestone Aug 3, 2023
@TTtie TTtie force-pushed the types/remove-guild-from-app-info branch from be6844d to 0c0309c Compare August 3, 2023 13:41
Per the newly released OpenAPI spec (https://github.com/discord/discord-api-spec), there doesn't even seem to be one... (structure PrivateApplicationResponse)
@TTtie TTtie force-pushed the types/remove-guild-from-app-info branch from 0c0309c to 9b757d1 Compare August 8, 2023 17:32
@TTtie
Copy link
Member Author

TTtie commented Nov 7, 2023

The status quo for the OAuthApplicationInfo#guild property has been resolved in #118 - I've got to know at least a rough idea of the guild type from the application objects found while inspecting app directory requests.

@TTtie TTtie closed this Nov 7, 2023
@TTtie TTtie deleted the types/remove-guild-from-app-info branch November 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: typings Issues or pull requests related to TypeScript definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant