-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HexGrid private and create HexSingleGrid and HexMultiGrid #1581
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
- Coverage 81.69% 81.62% -0.07%
==========================================
Files 18 18
Lines 1393 1399 +6
Branches 238 271 +33
==========================================
+ Hits 1138 1142 +4
- Misses 209 211 +2
Partials 46 46
☔ View full report in Codecov by Sentry. |
To ease backward compatibility, can you keep |
This seems like a good idea 👍 |
But I have not much time to work on this now, also it should be done with care I think since if we issue it in |
Actually did it |
Needs to resolve merge conflict. |
I don't see any merge conflict @rht , however I resolved one sometime ago |
I have rebased the branch. RTD build has a failure that is unrelated to this PR
@EwoutH any idea about the situation? |
Merged, thank you! |
Made HexGrid private and created two new grid classes as discussed in the dev meeting. This is a breaking change to defer until 2.0.