Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced tutorial notebook #1648

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Advanced tutorial notebook #1648

merged 4 commits into from
Apr 25, 2023

Conversation

jatinkhilnani
Copy link
Contributor

  • Updated advanced tutorial notebook for clarity and code/comment separation
  • Include supplementary python source file

@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (34eb008) 81.69% compared to head (6fd6dec) 81.69%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          18       18           
  Lines        1393     1393           
  Branches      271      271           
=======================================
  Hits         1138     1138           
  Misses        209      209           
  Partials       46       46

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jatinkhilnani jatinkhilnani force-pushed the advanced_tutorial_notebook branch 2 times, most recently from debc5ab to 6540318 Compare April 25, 2023 00:47
@jackiekazil
Copy link
Member

we have had some issues with the doc builds. Can you point this to the doc_build branch, so we can verify the build with readthedocs before we merge into main?

1 similar comment
@jackiekazil
Copy link
Member

we have had some issues with the doc builds. Can you point this to the doc_build branch, so we can verify the build with readthedocs before we merge into main?

@jackiekazil jackiekazil self-requested a review April 25, 2023 16:41
@jackiekazil jackiekazil added the Sprints! A task that might be good to tackle during sprints! label Apr 25, 2023
@jackiekazil jackiekazil changed the base branch from main to doc_builds April 25, 2023 17:46
@jackiekazil
Copy link
Member

I didn't realize I could change the branch. It is now pointed to doc_builds.

@jackiekazil
Copy link
Member

Tested. Looks good.

@jackiekazil jackiekazil merged commit cea5521 into projectmesa:doc_builds Apr 25, 2023
jackiekazil pushed a commit that referenced this pull request Apr 25, 2023
@jatinkhilnani @jackiekazil
Update pip statement for zsh & advanced tutorial notebook (#1648)
beb9c48
@tpike3 tpike3 added this to the Mesa 2.0 (Wellton) milestone Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackiekazil jackiekazil Awaiting requested review from jackiekazil

Assignees
No one assigned
Labels
Sprints! A task that might be good to tackle during sprints!
Projects
None yet
Milestone
Mesa 2.0 (Wellton)
Development

Successfully merging this pull request may close these issues.
3 participants
@jatinkhilnani @jackiekazil @tpike3