-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualisation: Allow different shapes agent portrayals#2164 #2171
Conversation
Performance benchmarks:
|
Thanks for the PR! Weird, seems totally unrelated to these changes or our CI. How are you committing? |
Regarding with the typos, we need to add |
I reset my project to an earlier state using Git. Now, I'm trying to re-install required dependencies like ruff and pytest, but I'm unable to activate the virtual environment (.venv). This prevents me from installing the packages currently. |
Can you share the error messages? |
Your .venv is probably gone (the other possibility is that .venv exists but .venv/bin/activate is not executable, but doesn't have to be executable anyway). You likely have to recreate the virtualenv from scratch. |
Maybe it's easiest to reinstall at this point. |
In CI all the tests are passing, so and the warnings are unrelated to this PR. So test-wise we’re good! Could you update the title of the PR and add a screenshot of how it now looks to the first PR message? |
Sorry, I mean a screenshot of how the visualisation looks with different shapes, to show that it works. |
How should show or generate visualization looks with different is their a test or dataset to show? |
You could adapt an example model, like: https://github.com/projectmesa/mesa-examples/tree/main/examples/boltzmann_wealth_model_experimental Or create a simple model yourself. |
@Aryan1Mahahjan would you still like to work on this? |
This now has been solved in #2214. |
Hi, this is Draft Solution to #2164.
I was thinking about using the below, which use the Encode function attribute
The added code snippet checks for shape and fill keys in agent data. If present, it adds them to the encoding_dict using the corresponding keys shape and fill. This allows you to define visual properties like circle shapes and filled elements for agents in your visualization.
Draft: Addition of 2 keys in enconding_dict: shape(str) and fill(bool)