Code coverage: ignore experimental and visualization #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
approved these changes
Oct 15, 2024
No, I think once the examples are merged we should include running them in the CI as soon as possible. And once they are run they should also be covered. If some lines are not covered than we probably need to fix the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised by @EwoutH frequent failing codecov tests can easily lead to missing other test failures.
This PR fixes the "experimental" ignore, because we can be more lenient with experimental features and introduces a "visualization" ignore. Code coverage is mostly meaningful for unit tests, but unit testing visualization code is not always helpful. We still should do something about testing our visualization, but this should primarily aim at integration tests, not unit tests.