add codecov token, fixes #2363

[Corvince]

Lets see if it works now

Closes #2363.

[quaquel]

seems to be working again!

[Corvince]

Yes! But we still miss the 90% target, so I lowered it temporarily to 80%. This is mostly caused by the deprecated time.py file, which is untested. Were the tests already removed or did they never exist? Anyways it would be unfair to have every PR fail because our project is currently undercovered, thats why i lowered it to 80%.

I also enabled a "fail_ci_if_error" flag, so hopefully we catch errors with codecov earlier next time. Or maybe it will cause too many errors, in which we can later disable it again. Lets see

[quaquel]

Yes! But we still miss the 90% target, so I lowered it temporarily to 80%. This is mostly caused by the deprecated time.py file, which is untested. Were the tests already removed or did they never exist? Anyways it would be unfair to have every PR fail because our project is currently undercovered, thats why i lowered it to 80%.

I agree. Not perse for this pr, but could we not exclude time.py somehow?

[Corvince]

Not sure how I would feel about this. Even when deprecated, I think its good to highlight gaps in our code coverage. Of course no one is going to write tests for time.py now, but since the 80% or 90% mark is arbitrary anyways I feel like including it is less cheating. But I don't have a strong opinion about that, so if someone else wants to open a PR to exclude it I wont reject it.

[quaquel]

There was a test_time.py that I think got removed when we deprecated it. This was unfortunate because although deprecated it is still being used in placed. Today I fixed #2359 which would not have been needed if test_time.py had not been removed. I'll try to remember adding it back in asap.

[EwoutH]

There was a test_time.py that I think got removed when we deprecated it.

Yeah sorry that's a mistake from my side, dully noted for future reference.

Thanks a lot for picking this up so quickly!