Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mistaken removal of _draw_grid #2398

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 22, 2024

As pointed out by @wang-boyu in #2386, there was a small mistake. I collapsed the drawing of continuous space and old style grid spaces. This fixes that mistake.

ps. I'll try to get some basic unit testing in place for the visualization stuff in the coming days.

@quaquel quaquel added the bug Release notes label label Oct 22, 2024
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +2.2% [+0.5%, +4.0%] 🔴 +3.9% [+3.8%, +4.1%]
BoltzmannWealth large 🔵 +2.8% [+2.4%, +3.2%] 🔴 +4.9% [+4.3%, +5.5%]
Schelling small 🔵 +0.4% [-0.0%, +0.8%] 🔵 +2.3% [+2.0%, +2.6%]
Schelling large 🔵 +2.8% [+1.8%, +3.7%] 🔵 +4.1% [+2.5%, +5.8%]
WolfSheep small 🔴 +3.7% [+3.3%, +4.1%] 🔴 +4.9% [+4.6%, +5.3%]
WolfSheep large 🔵 +0.6% [-0.5%, +1.7%] 🔵 +0.7% [-3.7%, +6.7%]
BoidFlockers small 🔵 +0.6% [+0.1%, +1.2%] 🔵 +2.4% [+1.8%, +3.0%]
BoidFlockers large 🔵 +1.7% [+0.9%, +2.6%] 🔵 +1.8% [+1.3%, +2.2%]

@quaquel quaquel merged commit f3ac06d into projectmesa:main Oct 22, 2024
13 of 14 checks passed
@quaquel quaquel deleted the fix_for_grids branch November 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants