Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Install manifest #648

Closed
scothis opened this issue Aug 7, 2018 · 2 comments
Closed

Install manifest #648

scothis opened this issue Aug 7, 2018 · 2 comments
Assignees
Milestone

Comments

@scothis
Copy link
Member

scothis commented Aug 7, 2018

Currently the installable resources are hard coded into the riff cli binary. This makes it very difficult to test new releases. Rather than expose the URL for each resource as a cli switch, we could define a manifest file that can then reference individual yaml files. A structured manifest will make it easier to pause for validation after installing Istio, or any other component that takes time to start.

A straw man proposal:

version: 0.1
istio: https://path/to/istio.yaml
system:
- https://path/to/knative-build.yaml
- https://path/to/knative-serving.yaml
- https://path/to/knative-eventing.yaml
- https://path/to/stub-clusterbus.yaml
namespace:
- https://path/to/riff-buildtemplate.yaml

cc @trisberg

@trisberg
Copy link
Member

trisberg commented Aug 8, 2018

I agree we need to externalize this and a manifest seems better than overriding individual URLs for the YAML artifacts

@jldec jldec added this to the Next milestone Aug 24, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 24, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 24, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 28, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 28, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 28, 2018
glyn added a commit to glyn/riff that referenced this issue Aug 28, 2018
@glyn
Copy link
Contributor

glyn commented Aug 28, 2018

  • Switch to istio and knative arrays in the manifest
  • Implement 5 second delay between installs of items in the istio array
  • Implement more specific global changes for items in the istio and knative arrays (s/type: LoadBalancer/type: NodePort/)
  • Provide a sample manifest which is equivalent to the hard-coded behaviour (in the future we can sync these up using code generation)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants