This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
Add --wait switch on riff function create #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this works out, we can do the same for other places where |
ericbottard
reviewed
Aug 28, 2018
| @@ -188,6 +189,13 @@ From then on you can use the sub-commands for the 'service' command to interact | |||
| "verbose", "v", verboseUsage, | |||
| ).NoOptDefVal = "true" | |||
|
|
|||
| command.Flags().VarPF( | |||
| BroadcastBoolValue(false, | |||
There was a problem hiding this comment.
A broadcast value only makes sense if it is applied to several variables. This can be simplified to a more traditional cobra flag
There was a problem hiding this comment.
@ericbottard Fair enough, but I was copying the pattern employed elsewhere. I would prefer to raise an issue to apply the simplification throughout rather than "step out of line" in this PR.
ericbottard
reviewed
Aug 28, 2018
cmd/commands/function.go
Outdated
| @@ -137,6 +137,7 @@ From then on you can use the sub-commands for the 'service' command to interact | |||
| } | |||
| } else { | |||
| printSuccessfulCompletion(cmd) | |||
| fmt.Fprintf(cmd.OutOrStdout(), "Issue `riff service status %s` to see the status of the function\n", fnName) | |||
There was a problem hiding this comment.
Should this be printed only if not using --wait/--verbose?
There was a problem hiding this comment.
@ericbottard Yes. Good catch. Fixed via force push.
|
Merged as 491d109 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #682