Fix task quantum unmarshall error from bind stats channel xml output #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Schoenbach <[email protected]>
SuperQ
approved these changes
Mar 22, 2023
|
It would be useful to update the test fixtures to add |
Signed-off-by: Benjamin Schoenbach <[email protected]>
done i put some negative values for v3 and v2 |
SuperQ
added a commit
that referenced
this pull request
Mar 22, 2023
* [BUGFIX] Fix nmarshall error for negative values #166 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Mar 22, 2023
* [BUGFIX] Fix unmarshall error for negative values #166 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Mar 22, 2023
* [BUGFIX] Fix unmarshall error for negative values #166 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes broken xml parse (unmarshall of possible negative task quantum attribute) within bind v9.18.12+ on statistics channel.