Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite current stable prometheus chart maintainers as collaborators with write access #12

Closed
2 tasks done
scottrigby opened this issue Aug 16, 2020 · 5 comments
Closed
2 tasks done

Comments

@scottrigby
Copy link
Member

scottrigby commented Aug 16, 2020

📊 Maintainers poll

Do we want to keep this level of granularity, or would it be better to give all collaborators write access to all charts in this repo? Let's discuss in comments below…

@asherf
Copy link
Member

asherf commented Aug 16, 2020

👋

@scottrigby
Copy link
Member Author

Invited all current maintainers as collaborators to this repo, and also pinged everyone in Slack ✅

@scottrigby
Copy link
Member Author

Will close this issue for now since tasks are done ✅ but we can still comment here in the meantime if there is overwhelming concern about implementation and re-open if needed ⏳

@Xtigyro
Copy link
Member

Xtigyro commented Aug 19, 2020

I believe we should keep the OWNERS file and the granularity because different people are involved in developing the different charts though closely related.

I do think though that we should all have owners permissions regarding the repo. This shouldn't take away from the actual permission to push commits/approve PRs for the different charts.

@scottrigby
Copy link
Member Author

@Xtigyro after slack chat, I understand what you mean. OK so yes, keeping CODEOWNERS file as-is, but can not change access level until after repo transfer. Also open questions about effects of combining that access level with CODEOWNERS file. Added all that to a new issue, to be addressed after the transfer: #20 Thanks!

This was referenced Sep 5, 2020
hectorj2f pushed a commit to hectorj2f/helm-charts that referenced this issue Nov 10, 2021
…-refactor-json-schema

Updates to image values format and JSON Schema for Rekor
sathieu pushed a commit to sathieu/helm-charts-prometheus-community that referenced this issue Nov 26, 2021
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
* Add externalTrafficPolicy for LB service

* Fix PR Comments
nf-npieros pushed a commit to nf-npieros/helm-charts that referenced this issue Jan 17, 2022
* Add externalTrafficPolicy for LB service

* Fix PR Comments
junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue Apr 7, 2023
[kube-prometheus-stack] change rules sync source to kse-prometheus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants