Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Can't find upgrade procedure from stable/prometheus-operator #84

Closed
TrustNoOne opened this issue Sep 10, 2020 · 5 comments · Fixed by #119
Closed
Labels
enhancement New feature or request

Comments

@TrustNoOne
Copy link

TrustNoOne commented Sep 10, 2020

Hi, I've been looking everywhere but I can't find how to upgrade stable/prometheus-operator to the renamed chart. I looked in open issues but found nothing.

I've never upgraded a renamed chart, I tried to look it up with no luck. Can anyone point me to that if it's anywhere?

I guess it's worth mentioning it in https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/README.md ?

@TrustNoOne TrustNoOne added the enhancement New feature or request label Sep 10, 2020
@den-is
Copy link
Contributor

den-is commented Sep 10, 2020

The easiest way is that you will have to do a clean reinstall from scratch :(

Virtually I can imagine that there is a way to migrate Prometheus data manually if it is stored in PVs to new PVs with new names - you can fake and create statefulset volumes by yourself - just match the name of these volumes with what the chart would do by itself.

@tbomberg
Copy link

It looks like upgrading the chart is possible by setting

nameOverride: prometheus-operator

in your values.yaml (or add it to the --set's in your helm upgrade commandline)
This way the generated object names stay the same as with the old chart.

@monotek
Copy link
Member

monotek commented Sep 11, 2020

@tbomberg
Would you mind to add this info to readme via a pr?

@scottrigby
Copy link
Member

scottrigby commented Sep 11, 2020

Thanks yes was thinking the same as @monotek here – a PR would be helpful 👍 Testing PVCs is one of the things we asked people to help with in #1, but I don't believe anyone did, and in the end I didn't have enough personal experience with persistence in this chart and it's subcharts to know what to test.

There is already this Migrating from coreos/prometheus-operator chart > Persistent Volumes section in the README. Do these steps help meet your need?

Either way, I would like to see a similar Upgrading from stable/prometheus-operator section as well. Including:

  • in-place release upgrade
  • recreate release with new chart, and (optionally) attach existing volume claims

The community could then continue adding to that section as new use cases upgrading from stable/prometheus-operator are defined.

@fktkrt
Copy link
Contributor

fktkrt commented Sep 20, 2020

I was not able to properly migrate using the solution described above.

Re-using existing PVs might be the most crucial step during this process mostly.
I've created a PR tackling this issue, and with those steps I was able to migrate my existing storage successfully to the new chart.

junotx pushed a commit to junotx/prometheus-helm-charts that referenced this issue Sep 14, 2024
…nity#84)

Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/helm/chart-releaser-action/releases)
- [Commits](helm/chart-releaser-action@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: helm/chart-releaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants