-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] Add upgrade path from stable/prometheus-operator #119
Merged
scottrigby
merged 17 commits into
prometheus-community:main
from
fktkrt:add-prometheus-operator-migration-guide
Oct 9, 2020
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
98a2015
add upgrade path from stable/prometheus-operator
fktkrt 0c87d89
bump chart
fktkrt 96e95f0
fix lint
fktkrt de00619
fix lint
fktkrt 09cfc5f
generalize object references
fktkrt 080e5d6
fix kubectl patch syntax, add missing step
fktkrt af2a23c
bump Chart version
fktkrt 52a236f
add step to remove legacy kubelet service
fktkrt a6c33b6
add instructions to specify AZ trough labels
fktkrt 304a1ed
Merge branch 'main' into add-prometheus-operator-migration-guide
fktkrt 8fcd692
remove unnecessary namespace reference, mention CRD provisioning, add…
fktkrt b58876e
Merge branch 'main' of https://github.com/fktkrt/helm-charts-1 into a…
fktkrt 2a8f015
Merge branch 'add-prometheus-operator-migration-guide' of https://git…
fktkrt 2ec1163
add volumeClaimTemplate example
fktkrt 7dd4680
Merge branch 'main' into add-prometheus-operator-migration-guide
scottrigby ec488cf
Fix markdownlint. Also change 'bash' to appropriate linguist codebloc…
scottrigby 952cfb6
Merge branch 'main' into add-prometheus-operator-migration-guide
scottrigby File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could some other unrelated PVC, created in between deletion of old PVC and creation of new one, take control of this PV?
Usually, when I do this kind of migration, I delete the old PVC, create the new one with correct PV reference, and edit the PV to point to the new PV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like this has been discussed below, but if there's a recommendation for mitigating this further let's update these instructions in a follow-up PR. Right now, there is no good documented migration path so this is an improvement.