[kube-prometheus-stack] multi tenant alert routing #1274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrobert13
requested review from
bismarck,
gianrubio,
gkarthiks,
scottrigby,
vsliouniaev and
Xtigyro
as code owners
Signed-off-by: Robert N <[email protected]> Signed-off-by: Robert Nemeti <[email protected]>
nrobert13
force-pushed
the
multi_tenant_alert_routing
branch
from
9326018
to
857cc34
Compare
monotek
requested changes
Aug 20, 2021
| @@ -18,7 +18,7 @@ name: kube-prometheus-stack | |||
| sources: | |||
| - https://github.com/prometheus-community/helm-charts | |||
| - https://github.com/prometheus-operator/kube-prometheus | |||
| version: 18.0.0 | |||
| version: 18.0.2 | |||
There was a problem hiding this comment.
adding new feature should raise chart minor version
There was a problem hiding this comment.
@monotek , thanks for the feedback. updated the minor version.
Signed-off-by: Robert Nemeti <[email protected]>
|
bump |
jorik90
suggested changes
Sep 3, 2021
There was a problem hiding this comment.
Two things worth noting:
- You've made changes in file that are generated. These changes will be overwritten.
- I've proposed an alternative solution to probably solve your problem. See my comment in kube-state alert routing in multi tenant cluster #1231 (comment)
| @@ -29,7 +29,10 @@ spec: | |||
| description: '{{`{{`}} printf "%.4g" $value {{`}}`}}% of the {{`{{`}} $labels.job {{`}}`}}/{{`{{`}} $labels.service {{`}}`}} targets in {{`{{`}} $labels.namespace {{`}}`}} namespace are down.' | |||
| runbook_url: {{ .Values.defaultRules.runbookUrl }}alert-name-targetdown | |||
| summary: One or more targets are unreachable. | |||
| expr: 100 * (count(up == 0) BY (job, namespace, service) / count(up) BY (job, namespace, service)) > 10 | |||
| expr: |- | |||
| {{ .Values.defaultRules.expressionPrefix }} | |||
There was a problem hiding this comment.
This is a change in a generated file (see the comment at the top of the file). When the next rules-sync is executed, your changes will be reverted.
|
thanks for the proposed solution. closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert N [email protected]
What this PR does / why we need it:
allow alert routing in multi tenant clusters to different teams
Which issue this PR fixes
(optional, in
fixes #<issue_number> (, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
hey @vsliouniaev , @bismarck, @gianrubio , @gkarthiks, @scottrigby, @Xtigyro, would you be so kind to review this change. Thanks in advance.
Cheers,
Robert
Checklist
[prometheus-couchdb-exporter])