formatted GitHub templates and made minor adjustments #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torsten Walter <[email protected]>
monotek
previously approved these changes
Sep 7, 2020
scottrigby
previously approved these changes
Sep 7, 2020
Signed-off-by: Torsten Walter <[email protected]>
torstenwalter
dismissed stale reviews from scottrigby and monotek
via
1256390
scottrigby
approved these changes
Sep 7, 2020
scottrigby
pushed a commit
that referenced
this pull request
Sep 9, 2020
* formatted GitHub templates and made minor adjustments Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]>
scottrigby
added a commit
that referenced
this pull request
Sep 9, 2020
* Initial chart direectory rename prometheus-operator to kube-prometheus See prometheus-community/community#28 (comment) Signed-off-by: Scott Rigby <[email protected]> * First attempt at data change of prometheus-operator to kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Helm GH Action files as-is from https://github.com/helm/charts-repo-actions-demo Signed-off-by: Scott Rigby <[email protected]> * Bump chart-testing action to v1.0.0. See helm/charts-repo-actions-demo#20 Signed-off-by: Scott Rigby <[email protected]> * Changes to chart testing config file for this repo Signed-off-by: Scott Rigby <[email protected]> * Use built-in GITHUB_TOKEN now that GH Actions bug is fixed. See helm/chart-releaser-action#26 Signed-off-by: Scott Rigby <[email protected]> * Test actions with version bump to prometheus chart Signed-off-by: Scott Rigby <[email protected]> * Bump chart-releaser-action and kind-action to v1.0.0 Signed-off-by: Scott Rigby <[email protected]> * Release from main not master branch Signed-off-by: Scott Rigby <[email protected]> * Revert "Test actions with version bump to prometheus chart" This reverts commit 81c50e5. Signed-off-by: Scott Rigby <[email protected]> * Allow requirements lock files Signed-off-by: Scott Rigby <[email protected]> * Initial CODEOWNERS file (#18) Signed-off-by: Scott Rigby <[email protected]> * Prep initial charts indexing (#14) * [stable/prometheus] update prometheus to 2.20.1 and cm reloader to 0.4.0 (#23506) * updated prometheus to 2.20.1 and cm reloader to 0.4.0 Signed-off-by: André Bauer <[email protected]> * fix xpp version Signed-off-by: André Bauer <[email protected]> * Deprecate prometheus-operator chart before helm repo index, so that it won't be listed in the hubs Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-community/prometheus chart. Needed to update references to stable repo, but took the opportunity to reorganize, fix and simplify README Signed-off-by: Scott Rigby <[email protected]> * Add Helm 3 commands before Helm 2. Add helm update command. Reorganize the 'Upgrading Chart' section Signed-off-by: Scott Rigby <[email protected]> * Fix header Signed-off-by: Scott Rigby <[email protected]> * Fix markdown linting Signed-off-by: Scott Rigby <[email protected]> * Add direct links to values.yaml configuration file for easy browsing by end users without the CLI Signed-off-by: Scott Rigby <[email protected]> * Remove prometheus chart OWNERS file Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-adapter chart README and bump version Signed-off-by: Scott Rigby <[email protected]> * prometheus chart: Return updated, working command example for Sharing Alerts Between Services Signed-off-by: Scott Rigby <[email protected]> * prometheus-adapter: fix configure command typos Signed-off-by: Scott Rigby <[email protected]> * prometheus-blackbox-exporter: Update readme, delete OWNERS file and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-cloudwatch-exporter: Update Readme with new template, delete OWNERS file, bump chart version, update CHANGELOG Signed-off-by: Scott Rigby <[email protected]> * prometheus-consul-exporter: Update Readme per new template and bump chart Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Update Readme per new template and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-mongodb-exporter: Update Readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix k8s 1.16 deprecated PodSecurityPolicy in the extensions/v1beta1 API version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix bad YAML indentation. How did this ever work? Signed-off-by: Scott Rigby <[email protected]> * prometheus-mysql-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-nats-exporter: update readme per new template, move specific config note to values.yaml, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-node-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-postgres-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-pushgateway: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-rabbitmq-exporter: update readme per new template, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-redis-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-snmp-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: fix deprecated deployment apps/v1beta1 Signed-off-by: Scott Rigby <[email protected]> * Remove instructions for stable repos from all charts, except prometheus and deprecated prometheus-operator, as only those have dependencies on stable charts Signed-off-by: Scott Rigby <[email protected]> * Temporary workaround github API rate limiting Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec Signed-off-by: Scott Rigby <[email protected]> * disable chart testing for prometheus-to-sd. If not running on GCE, will error: "Failed to get GCE config" Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> * Add kube-prometheus chart maintainers to CODEOWNERS after merging main Signed-off-by: Scott Rigby <[email protected]> * Un-deprecate chart within renaming to kube-prometheus PR Signed-off-by: Scott Rigby <[email protected]> * Change all references to old coreos/prometheus-operator and coreos/kube-prometheus git repos to the new prometheus-operator github org Signed-off-by: Scott Rigby <[email protected]> * Remove stray CODEOWNERS rule for charts/prometheus-operator/ Signed-off-by: Scott Rigby <[email protected]> * Fix typo Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/prometheus-operator.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node.rules.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-network.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-time.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/kubernetes-system.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update dependency location and remove README note about chart source (it's easy to determine chart source from the dependency definition) Signed-off-by: Scott Rigby <[email protected]> * Fix markdownlint Signed-off-by: Scott Rigby <[email protected]> * Update kube-prometheus per new README template. See #14 Signed-off-by: Scott Rigby <[email protected]> * Remove requirements lock file for now, otherwise if we release the chart before transferring repo ownership the digest will differ. See helm pkg downloader Manager Build() method check for resolveRepoNames() Signed-off-by: Scott Rigby <[email protected]> * Non-functional: update commented links to CRD sources Co-authored-by: Quentin Bisson <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add GitHub superlinter to lint markdown (#26) * Create linter.yml Signed-off-by: Torsten Walter <[email protected]> Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add configuration for Stale GitHub app (#27) Signed-off-by: Scott Rigby <[email protected]> * disabled failing linters and fixed markdown issues (#32) - fixes markdown issues reported by markdownlint - disabled yamllint as helm templates are never valid - disabled the other linters as there is a problem with a shell script and some python code once that is fixed we could enable them again Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Rename chart dir Signed-off-by: Scott Rigby <[email protected]> * Update CODEOWNERS for new chart dir name Signed-off-by: Scott Rigby <[email protected]> * Rename instances of kube-prometheus to kube-prometheus-stack. Take care to leave references to the upstream kube-prometheus project (and related configs) as kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Chart testing needs this repo info to test chart dependencies in the same repo Signed-off-by: Scott Rigby <[email protected]> * Auto-sync README from main to gh-pages (#41) * Auto-sync README from main to gh-pages Signed-off-by: Scott Rigby <[email protected]> * Only runs on push to main even if this workflow is copied to a new branch Signed-off-by: Scott Rigby <[email protected]> * Improve README for main and gh pages (#43) Signed-off-by: Scott Rigby <[email protected]> * [prometheus] unify labels and annotations across all deploymens and statefulsets (#45) Signed-off-by: Ondrej Homolka <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-redis-exporter] Add zanhsieh as maintainer (#46) Signed-off-by: zanhsieh <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * added link to github to readme (#51) Signed-off-by: André Bauer <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add PROCESSES document (#44) * Add CODEOWNERS I used this syntax in CODEOWNERS: ``` /chart/<name-of-chart> @maintainer ``` It matches any files in the chart directory at the root of the repository and any of its subdirectories. Without the leading `/` it would also match directories found somewhere else. It's unlikely that those names would be used, but it does not harm to do it this way. Part-of: #38 Signed-off-by: Torsten Walter <[email protected]> * sort charts alphabetically Signed-off-by: Torsten Walter <[email protected]> * adjust existing CODEOWNERS Signed-off-by: Torsten Walter <[email protected]> * link to CODEOWNERS file and fixed spelling Signed-off-by: Torsten Walter <[email protected]> * feat: adding issue templates (#54) * feat: adding issue templates Signed-off-by: gkarthiks <[email protected]> * feat: PR template and review comments Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-consul-exporter] add gkarthiks as additional maintainers (#50) * adding gkarthiks for additional maintainers Signed-off-by: gkarthiks <[email protected]> * fix: new line char Signed-off-by: gkarthiks <[email protected]> * adding gkarthiks to codeowners against consul Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus] - adds monotek to prometheus maintainers (#55) * added monotek to prometheus maintainers Signed-off-by: André Bauer <[email protected]> * rearrange the new codeowner for prometheus chart Signed-off-by: Xtigyro <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-blackbox-exporter] fix linting failure due to deprecated api version (see issue #56) (#57) * fix linting failure due to deprecated api version (see issue #56) Signed-off-by: Jorrit Salverda <[email protected]> * use rbac.apiVersion template to set correct apiVersion for role and rolebinding Signed-off-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * formatted GitHub templates and made minor adjustments (#59) * formatted GitHub templates and made minor adjustments Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [kube-prometheus-stack] Fix Chart Name and Rm Whitespaces in "NOTES.txt" (#60) * fix chart name in NOTES.txt Signed-off-by: Xtigyro <[email protected]> * rm whitespaces in NOTES.txt Signed-off-by: Xtigyro <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * feat: replacing grafana rom stable to its own repo + additional chart maintainer (#53) * feat: replacing grafana own repo Signed-off-by: gkarthiks <[email protected]> * fix: trailing white spaces Signed-off-by: gkarthiks <[email protected]> * fix: reverting the grafana values Signed-off-by: gkarthiks <[email protected]> * adding grafana repo for actions Signed-off-by: gkarthiks <[email protected]> * add: adding grafana repo in linter Signed-off-by: gkarthiks <[email protected]> * doc(lint): making doc stmt as single stmt Signed-off-by: gkarthiks <[email protected]> * revert: reverting the old README statement Signed-off-by: gkarthiks <[email protected]> * feat: adding gkarthiks to codeowners against kube-prometheus-stack Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Karthikeyan Govindaraj <[email protected]> * Add scottrigby as co-maintainer of kube-prometheus-stack Signed-off-by: Scott Rigby <[email protected]> * add xtigyro as maintainer for kube-prometheus-stack (#73) Signed-off-by: Miroslav Hadzhiev <[email protected]> * Revert header for simplicity Co-authored-by: Cédric de Saint Martin <[email protected]> Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Co-authored-by: Torsten Walter <[email protected]> Co-authored-by: hmlkao <[email protected]> Co-authored-by: zanhsieh <[email protected]> Co-authored-by: Karthikeyan Govindaraj <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Co-authored-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]>
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
…munity#59) * formatted GitHub templates and made minor adjustments Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: André Bauer <[email protected]>
monotek
pushed a commit
to monotek/prometheus-helm-charts
that referenced
this pull request
Oct 7, 2020
* Initial chart direectory rename prometheus-operator to kube-prometheus See prometheus-community/community#28 (comment) Signed-off-by: Scott Rigby <[email protected]> * First attempt at data change of prometheus-operator to kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Helm GH Action files as-is from https://github.com/helm/charts-repo-actions-demo Signed-off-by: Scott Rigby <[email protected]> * Bump chart-testing action to v1.0.0. See helm/charts-repo-actions-demo#20 Signed-off-by: Scott Rigby <[email protected]> * Changes to chart testing config file for this repo Signed-off-by: Scott Rigby <[email protected]> * Use built-in GITHUB_TOKEN now that GH Actions bug is fixed. See helm/chart-releaser-action#26 Signed-off-by: Scott Rigby <[email protected]> * Test actions with version bump to prometheus chart Signed-off-by: Scott Rigby <[email protected]> * Bump chart-releaser-action and kind-action to v1.0.0 Signed-off-by: Scott Rigby <[email protected]> * Release from main not master branch Signed-off-by: Scott Rigby <[email protected]> * Revert "Test actions with version bump to prometheus chart" This reverts commit 81c50e5. Signed-off-by: Scott Rigby <[email protected]> * Allow requirements lock files Signed-off-by: Scott Rigby <[email protected]> * Initial CODEOWNERS file (prometheus-community#18) Signed-off-by: Scott Rigby <[email protected]> * Prep initial charts indexing (prometheus-community#14) * [stable/prometheus] update prometheus to 2.20.1 and cm reloader to 0.4.0 (#23506) * updated prometheus to 2.20.1 and cm reloader to 0.4.0 Signed-off-by: André Bauer <[email protected]> * fix xpp version Signed-off-by: André Bauer <[email protected]> * Deprecate prometheus-operator chart before helm repo index, so that it won't be listed in the hubs Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-community/prometheus chart. Needed to update references to stable repo, but took the opportunity to reorganize, fix and simplify README Signed-off-by: Scott Rigby <[email protected]> * Add Helm 3 commands before Helm 2. Add helm update command. Reorganize the 'Upgrading Chart' section Signed-off-by: Scott Rigby <[email protected]> * Fix header Signed-off-by: Scott Rigby <[email protected]> * Fix markdown linting Signed-off-by: Scott Rigby <[email protected]> * Add direct links to values.yaml configuration file for easy browsing by end users without the CLI Signed-off-by: Scott Rigby <[email protected]> * Remove prometheus chart OWNERS file Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-adapter chart README and bump version Signed-off-by: Scott Rigby <[email protected]> * prometheus chart: Return updated, working command example for Sharing Alerts Between Services Signed-off-by: Scott Rigby <[email protected]> * prometheus-adapter: fix configure command typos Signed-off-by: Scott Rigby <[email protected]> * prometheus-blackbox-exporter: Update readme, delete OWNERS file and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-cloudwatch-exporter: Update Readme with new template, delete OWNERS file, bump chart version, update CHANGELOG Signed-off-by: Scott Rigby <[email protected]> * prometheus-consul-exporter: Update Readme per new template and bump chart Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Update Readme per new template and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-mongodb-exporter: Update Readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix k8s 1.16 deprecated PodSecurityPolicy in the extensions/v1beta1 API version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix bad YAML indentation. How did this ever work? Signed-off-by: Scott Rigby <[email protected]> * prometheus-mysql-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-nats-exporter: update readme per new template, move specific config note to values.yaml, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-node-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-postgres-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-pushgateway: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-rabbitmq-exporter: update readme per new template, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-redis-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-snmp-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: fix deprecated deployment apps/v1beta1 Signed-off-by: Scott Rigby <[email protected]> * Remove instructions for stable repos from all charts, except prometheus and deprecated prometheus-operator, as only those have dependencies on stable charts Signed-off-by: Scott Rigby <[email protected]> * Temporary workaround github API rate limiting Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec Signed-off-by: Scott Rigby <[email protected]> * disable chart testing for prometheus-to-sd. If not running on GCE, will error: "Failed to get GCE config" Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> * Add kube-prometheus chart maintainers to CODEOWNERS after merging main Signed-off-by: Scott Rigby <[email protected]> * Un-deprecate chart within renaming to kube-prometheus PR Signed-off-by: Scott Rigby <[email protected]> * Change all references to old coreos/prometheus-operator and coreos/kube-prometheus git repos to the new prometheus-operator github org Signed-off-by: Scott Rigby <[email protected]> * Remove stray CODEOWNERS rule for charts/prometheus-operator/ Signed-off-by: Scott Rigby <[email protected]> * Fix typo Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/prometheus-operator.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node.rules.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-network.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-time.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/kubernetes-system.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update dependency location and remove README note about chart source (it's easy to determine chart source from the dependency definition) Signed-off-by: Scott Rigby <[email protected]> * Fix markdownlint Signed-off-by: Scott Rigby <[email protected]> * Update kube-prometheus per new README template. See prometheus-community#14 Signed-off-by: Scott Rigby <[email protected]> * Remove requirements lock file for now, otherwise if we release the chart before transferring repo ownership the digest will differ. See helm pkg downloader Manager Build() method check for resolveRepoNames() Signed-off-by: Scott Rigby <[email protected]> * Non-functional: update commented links to CRD sources Co-authored-by: Quentin Bisson <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add GitHub superlinter to lint markdown (prometheus-community#26) * Create linter.yml Signed-off-by: Torsten Walter <[email protected]> Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add configuration for Stale GitHub app (prometheus-community#27) Signed-off-by: Scott Rigby <[email protected]> * disabled failing linters and fixed markdown issues (prometheus-community#32) - fixes markdown issues reported by markdownlint - disabled yamllint as helm templates are never valid - disabled the other linters as there is a problem with a shell script and some python code once that is fixed we could enable them again Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Rename chart dir Signed-off-by: Scott Rigby <[email protected]> * Update CODEOWNERS for new chart dir name Signed-off-by: Scott Rigby <[email protected]> * Rename instances of kube-prometheus to kube-prometheus-stack. Take care to leave references to the upstream kube-prometheus project (and related configs) as kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Chart testing needs this repo info to test chart dependencies in the same repo Signed-off-by: Scott Rigby <[email protected]> * Auto-sync README from main to gh-pages (prometheus-community#41) * Auto-sync README from main to gh-pages Signed-off-by: Scott Rigby <[email protected]> * Only runs on push to main even if this workflow is copied to a new branch Signed-off-by: Scott Rigby <[email protected]> * Improve README for main and gh pages (prometheus-community#43) Signed-off-by: Scott Rigby <[email protected]> * [prometheus] unify labels and annotations across all deploymens and statefulsets (prometheus-community#45) Signed-off-by: Ondrej Homolka <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-redis-exporter] Add zanhsieh as maintainer (prometheus-community#46) Signed-off-by: zanhsieh <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * added link to github to readme (prometheus-community#51) Signed-off-by: André Bauer <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add PROCESSES document (prometheus-community#44) * Add CODEOWNERS I used this syntax in CODEOWNERS: ``` /chart/<name-of-chart> @maintainer ``` It matches any files in the chart directory at the root of the repository and any of its subdirectories. Without the leading `/` it would also match directories found somewhere else. It's unlikely that those names would be used, but it does not harm to do it this way. Part-of: prometheus-community#38 Signed-off-by: Torsten Walter <[email protected]> * sort charts alphabetically Signed-off-by: Torsten Walter <[email protected]> * adjust existing CODEOWNERS Signed-off-by: Torsten Walter <[email protected]> * link to CODEOWNERS file and fixed spelling Signed-off-by: Torsten Walter <[email protected]> * feat: adding issue templates (prometheus-community#54) * feat: adding issue templates Signed-off-by: gkarthiks <[email protected]> * feat: PR template and review comments Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-consul-exporter] add gkarthiks as additional maintainers (prometheus-community#50) * adding gkarthiks for additional maintainers Signed-off-by: gkarthiks <[email protected]> * fix: new line char Signed-off-by: gkarthiks <[email protected]> * adding gkarthiks to codeowners against consul Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus] - adds monotek to prometheus maintainers (prometheus-community#55) * added monotek to prometheus maintainers Signed-off-by: André Bauer <[email protected]> * rearrange the new codeowner for prometheus chart Signed-off-by: Xtigyro <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-blackbox-exporter] fix linting failure due to deprecated api version (see issue prometheus-community#56) (prometheus-community#57) * fix linting failure due to deprecated api version (see issue prometheus-community#56) Signed-off-by: Jorrit Salverda <[email protected]> * use rbac.apiVersion template to set correct apiVersion for role and rolebinding Signed-off-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * formatted GitHub templates and made minor adjustments (prometheus-community#59) * formatted GitHub templates and made minor adjustments Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [kube-prometheus-stack] Fix Chart Name and Rm Whitespaces in "NOTES.txt" (prometheus-community#60) * fix chart name in NOTES.txt Signed-off-by: Xtigyro <[email protected]> * rm whitespaces in NOTES.txt Signed-off-by: Xtigyro <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * feat: replacing grafana rom stable to its own repo + additional chart maintainer (prometheus-community#53) * feat: replacing grafana own repo Signed-off-by: gkarthiks <[email protected]> * fix: trailing white spaces Signed-off-by: gkarthiks <[email protected]> * fix: reverting the grafana values Signed-off-by: gkarthiks <[email protected]> * adding grafana repo for actions Signed-off-by: gkarthiks <[email protected]> * add: adding grafana repo in linter Signed-off-by: gkarthiks <[email protected]> * doc(lint): making doc stmt as single stmt Signed-off-by: gkarthiks <[email protected]> * revert: reverting the old README statement Signed-off-by: gkarthiks <[email protected]> * feat: adding gkarthiks to codeowners against kube-prometheus-stack Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Karthikeyan Govindaraj <[email protected]> * Add scottrigby as co-maintainer of kube-prometheus-stack Signed-off-by: Scott Rigby <[email protected]> * add xtigyro as maintainer for kube-prometheus-stack (prometheus-community#73) Signed-off-by: Miroslav Hadzhiev <[email protected]> * Revert header for simplicity Co-authored-by: Cédric de Saint Martin <[email protected]> Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Co-authored-by: Torsten Walter <[email protected]> Co-authored-by: hmlkao <[email protected]> Co-authored-by: zanhsieh <[email protected]> Co-authored-by: Karthikeyan Govindaraj <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Co-authored-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]> Signed-off-by: André Bauer <[email protected]>
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
nf-npieros
pushed a commit
to nf-npieros/helm-charts
that referenced
this pull request
Jan 17, 2022
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…munity#1) * Initial chart direectory rename prometheus-operator to kube-prometheus See prometheus-community/community#28 (comment) Signed-off-by: Scott Rigby <[email protected]> * First attempt at data change of prometheus-operator to kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Helm GH Action files as-is from https://github.com/helm/charts-repo-actions-demo Signed-off-by: Scott Rigby <[email protected]> * Bump chart-testing action to v1.0.0. See helm/charts-repo-actions-demo#20 Signed-off-by: Scott Rigby <[email protected]> * Changes to chart testing config file for this repo Signed-off-by: Scott Rigby <[email protected]> * Use built-in GITHUB_TOKEN now that GH Actions bug is fixed. See helm/chart-releaser-action#26 Signed-off-by: Scott Rigby <[email protected]> * Test actions with version bump to prometheus chart Signed-off-by: Scott Rigby <[email protected]> * Bump chart-releaser-action and kind-action to v1.0.0 Signed-off-by: Scott Rigby <[email protected]> * Release from main not master branch Signed-off-by: Scott Rigby <[email protected]> * Revert "Test actions with version bump to prometheus chart" This reverts commit 81c50e5. Signed-off-by: Scott Rigby <[email protected]> * Allow requirements lock files Signed-off-by: Scott Rigby <[email protected]> * Initial CODEOWNERS file (prometheus-community#18) Signed-off-by: Scott Rigby <[email protected]> * Prep initial charts indexing (prometheus-community#14) * [stable/prometheus] update prometheus to 2.20.1 and cm reloader to 0.4.0 (#23506) * updated prometheus to 2.20.1 and cm reloader to 0.4.0 Signed-off-by: André Bauer <[email protected]> * fix xpp version Signed-off-by: André Bauer <[email protected]> * Deprecate prometheus-operator chart before helm repo index, so that it won't be listed in the hubs Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-community/prometheus chart. Needed to update references to stable repo, but took the opportunity to reorganize, fix and simplify README Signed-off-by: Scott Rigby <[email protected]> * Add Helm 3 commands before Helm 2. Add helm update command. Reorganize the 'Upgrading Chart' section Signed-off-by: Scott Rigby <[email protected]> * Fix header Signed-off-by: Scott Rigby <[email protected]> * Fix markdown linting Signed-off-by: Scott Rigby <[email protected]> * Add direct links to values.yaml configuration file for easy browsing by end users without the CLI Signed-off-by: Scott Rigby <[email protected]> * Remove prometheus chart OWNERS file Signed-off-by: Scott Rigby <[email protected]> * Update prometheus-adapter chart README and bump version Signed-off-by: Scott Rigby <[email protected]> * prometheus chart: Return updated, working command example for Sharing Alerts Between Services Signed-off-by: Scott Rigby <[email protected]> * prometheus-adapter: fix configure command typos Signed-off-by: Scott Rigby <[email protected]> * prometheus-blackbox-exporter: Update readme, delete OWNERS file and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-cloudwatch-exporter: Update Readme with new template, delete OWNERS file, bump chart version, update CHANGELOG Signed-off-by: Scott Rigby <[email protected]> * prometheus-consul-exporter: Update Readme per new template and bump chart Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Update Readme per new template and bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-mongodb-exporter: Update Readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix k8s 1.16 deprecated PodSecurityPolicy in the extensions/v1beta1 API version Signed-off-by: Scott Rigby <[email protected]> * prometheus-couchdb-exporter: Fix bad YAML indentation. How did this ever work? Signed-off-by: Scott Rigby <[email protected]> * prometheus-mysql-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-nats-exporter: update readme per new template, move specific config note to values.yaml, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-node-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-postgres-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-pushgateway: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-rabbitmq-exporter: update readme per new template, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-redis-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-snmp-exporter: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: update readme per new template, remove OWNERS file, bump chart version Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: fix deprecated deployment apps/v1beta1 Signed-off-by: Scott Rigby <[email protected]> * Remove instructions for stable repos from all charts, except prometheus and deprecated prometheus-operator, as only those have dependencies on stable charts Signed-off-by: Scott Rigby <[email protected]> * Temporary workaround github API rate limiting Signed-off-by: Scott Rigby <[email protected]> * prometheus-to-sd: missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec Signed-off-by: Scott Rigby <[email protected]> * disable chart testing for prometheus-to-sd. If not running on GCE, will error: "Failed to get GCE config" Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> * Add kube-prometheus chart maintainers to CODEOWNERS after merging main Signed-off-by: Scott Rigby <[email protected]> * Un-deprecate chart within renaming to kube-prometheus PR Signed-off-by: Scott Rigby <[email protected]> * Change all references to old coreos/prometheus-operator and coreos/kube-prometheus git repos to the new prometheus-operator github org Signed-off-by: Scott Rigby <[email protected]> * Remove stray CODEOWNERS rule for charts/prometheus-operator/ Signed-off-by: Scott Rigby <[email protected]> * Fix typo Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/hack/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/prometheus-operator.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node.rules.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-network.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/node-time.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/templates/prometheus/rules/kubernetes-system.yaml Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update charts/kube-prometheus/README.md Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Update dependency location and remove README note about chart source (it's easy to determine chart source from the dependency definition) Signed-off-by: Scott Rigby <[email protected]> * Fix markdownlint Signed-off-by: Scott Rigby <[email protected]> * Update kube-prometheus per new README template. See prometheus-community#14 Signed-off-by: Scott Rigby <[email protected]> * Remove requirements lock file for now, otherwise if we release the chart before transferring repo ownership the digest will differ. See helm pkg downloader Manager Build() method check for resolveRepoNames() Signed-off-by: Scott Rigby <[email protected]> * Non-functional: update commented links to CRD sources Co-authored-by: Quentin Bisson <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add GitHub superlinter to lint markdown (prometheus-community#26) * Create linter.yml Signed-off-by: Torsten Walter <[email protected]> Co-authored-by: Scott Rigby <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add configuration for Stale GitHub app (prometheus-community#27) Signed-off-by: Scott Rigby <[email protected]> * disabled failing linters and fixed markdown issues (prometheus-community#32) - fixes markdown issues reported by markdownlint - disabled yamllint as helm templates are never valid - disabled the other linters as there is a problem with a shell script and some python code once that is fixed we could enable them again Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Rename chart dir Signed-off-by: Scott Rigby <[email protected]> * Update CODEOWNERS for new chart dir name Signed-off-by: Scott Rigby <[email protected]> * Rename instances of kube-prometheus to kube-prometheus-stack. Take care to leave references to the upstream kube-prometheus project (and related configs) as kube-prometheus Signed-off-by: Scott Rigby <[email protected]> * Chart testing needs this repo info to test chart dependencies in the same repo Signed-off-by: Scott Rigby <[email protected]> * Auto-sync README from main to gh-pages (prometheus-community#41) * Auto-sync README from main to gh-pages Signed-off-by: Scott Rigby <[email protected]> * Only runs on push to main even if this workflow is copied to a new branch Signed-off-by: Scott Rigby <[email protected]> * Improve README for main and gh pages (prometheus-community#43) Signed-off-by: Scott Rigby <[email protected]> * [prometheus] unify labels and annotations across all deploymens and statefulsets (prometheus-community#45) Signed-off-by: Ondrej Homolka <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-redis-exporter] Add zanhsieh as maintainer (prometheus-community#46) Signed-off-by: zanhsieh <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * added link to github to readme (prometheus-community#51) Signed-off-by: André Bauer <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * Add PROCESSES document (prometheus-community#44) * Add CODEOWNERS I used this syntax in CODEOWNERS: ``` /chart/<name-of-chart> @maintainer ``` It matches any files in the chart directory at the root of the repository and any of its subdirectories. Without the leading `/` it would also match directories found somewhere else. It's unlikely that those names would be used, but it does not harm to do it this way. Part-of: prometheus-community#38 Signed-off-by: Torsten Walter <[email protected]> * sort charts alphabetically Signed-off-by: Torsten Walter <[email protected]> * adjust existing CODEOWNERS Signed-off-by: Torsten Walter <[email protected]> * link to CODEOWNERS file and fixed spelling Signed-off-by: Torsten Walter <[email protected]> * feat: adding issue templates (prometheus-community#54) * feat: adding issue templates Signed-off-by: gkarthiks <[email protected]> * feat: PR template and review comments Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-consul-exporter] add gkarthiks as additional maintainers (prometheus-community#50) * adding gkarthiks for additional maintainers Signed-off-by: gkarthiks <[email protected]> * fix: new line char Signed-off-by: gkarthiks <[email protected]> * adding gkarthiks to codeowners against consul Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus] - adds monotek to prometheus maintainers (prometheus-community#55) * added monotek to prometheus maintainers Signed-off-by: André Bauer <[email protected]> * rearrange the new codeowner for prometheus chart Signed-off-by: Xtigyro <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [prometheus-blackbox-exporter] fix linting failure due to deprecated api version (see issue prometheus-community#56) (prometheus-community#57) * fix linting failure due to deprecated api version (see issue prometheus-community#56) Signed-off-by: Jorrit Salverda <[email protected]> * use rbac.apiVersion template to set correct apiVersion for role and rolebinding Signed-off-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * formatted GitHub templates and made minor adjustments (prometheus-community#59) * formatted GitHub templates and made minor adjustments Signed-off-by: Torsten Walter <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * [kube-prometheus-stack] Fix Chart Name and Rm Whitespaces in "NOTES.txt" (prometheus-community#60) * fix chart name in NOTES.txt Signed-off-by: Xtigyro <[email protected]> * rm whitespaces in NOTES.txt Signed-off-by: Xtigyro <[email protected]> Signed-off-by: Scott Rigby <[email protected]> * feat: replacing grafana rom stable to its own repo + additional chart maintainer (prometheus-community#53) * feat: replacing grafana own repo Signed-off-by: gkarthiks <[email protected]> * fix: trailing white spaces Signed-off-by: gkarthiks <[email protected]> * fix: reverting the grafana values Signed-off-by: gkarthiks <[email protected]> * adding grafana repo for actions Signed-off-by: gkarthiks <[email protected]> * add: adding grafana repo in linter Signed-off-by: gkarthiks <[email protected]> * doc(lint): making doc stmt as single stmt Signed-off-by: gkarthiks <[email protected]> * revert: reverting the old README statement Signed-off-by: gkarthiks <[email protected]> * feat: adding gkarthiks to codeowners against kube-prometheus-stack Signed-off-by: gkarthiks <[email protected]> Signed-off-by: Karthikeyan Govindaraj <[email protected]> * Add scottrigby as co-maintainer of kube-prometheus-stack Signed-off-by: Scott Rigby <[email protected]> * add xtigyro as maintainer for kube-prometheus-stack (prometheus-community#73) Signed-off-by: Miroslav Hadzhiev <[email protected]> * Revert header for simplicity Co-authored-by: Cédric de Saint Martin <[email protected]> Signed-off-by: Scott Rigby <[email protected]> Co-authored-by: André Bauer <[email protected]> Co-authored-by: Manuel Rüger <[email protected]> Co-authored-by: Torsten Walter <[email protected]> Co-authored-by: hmlkao <[email protected]> Co-authored-by: zanhsieh <[email protected]> Co-authored-by: Karthikeyan Govindaraj <[email protected]> Co-authored-by: Miroslav Hadzhiev <[email protected]> Co-authored-by: Jorrit Salverda <[email protected]> Signed-off-by: Scott Rigby <[email protected]>
junotx
pushed a commit
to junotx/prometheus-helm-charts
that referenced
this pull request
Apr 24, 2024
[alertmanager] support to auto set replicas by node num
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist