Builds are not triggered on main branch so container image isn't produced

[jsturtevant]

In #864 some logic was added to build a "bleeding edge" container:

windows_exporter/.github/workflows/ci.yml

Lines 180 to 185 in 5106b82

	- name: Push Latest image
	if: ${{ github.event_name != 'pull_request' }}
	env:
	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
	run: |
	VERSION=latest make push-all

This doesn't trigger currently because the workflow only runs on PR's and tags:

windows_exporter/.github/workflows/ci.yml

Lines 5 to 12 in 5106b82

	on:
	pull_request:
	branches:
	- master
	release:
	types:
	- published
	- edited

Adding a trigger like

on:
  push:
    branches: [ master ]

would build, test and then push the bleeding edge image as well give a signal that main branch is healthy after the PR merge. @breed808 @carlpett any thoughts on this?

[breed808]

Agreed, we'll need to enable CI for pushes to master to get this working.

[breed808]

master CI job is failing when attempting to build container images. Will need to investigate and resolve.

docker build --build-arg=BASE=mcr.microsoft.com/windows/nanoserver:1809 -f Dockerfile -t ghcr.io/prometheus-community/windows-exporter:0.18.2+11-1809 .
invalid argument "ghcr.io/prometheus-community/windows-exporter:0.18.2+11-1809" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.

[breed808]

I think the plus ('+') in the tag name is causing the failure. From the docker documentation:

A tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes. A tag name may not start with a period or a dash and may contain a maximum of 128 characters.

[jsturtevant]

Thanks for working through the fixes! Sorry these slipped through my testing.

Looks like the image is available now: https://github.com/prometheus-community/windows_exporter/pkgs/container/windows-exporter 🥳