Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build issues #948

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Fix image build issues #948

merged 2 commits into from
Feb 27, 2022

Conversation

breed808
Copy link
Contributor

master image builds have been failing due to invalid characters in the tag name (Build step) and incorrect environment variable setting (Push Latest image step).

Resolves #940

Powershell uses $Env: prefix for environment variables.

Signed-off-by: Ben Reedy <[email protected]>
Copy link
Collaborator

@carlpett carlpett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breed808 breed808 merged commit 4d2a247 into prometheus-community:master Feb 27, 2022
@breed808 breed808 deleted the ci_tag_name branch February 27, 2022 08:51
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds are not triggered on main branch so container image isn't produced
2 participants