-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perfdata: add experimental generic collector #1459
Conversation
Seems this might resolve #1414 as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on getting this implemented! I've left a few minor questions, let me know if they require any clarification.
a2fa493
to
7236f6a
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Ref #1350
Fixes #1414
This PR setup a generic performance data collectors based on the users configuration.
Instead existing collectors that is using the perflib, the perfdata collector using the Performance Data Helpers function. See #1350
Implement the Performance Data Helpers as separate collector may have multiple oppunities:
It's easier to compare data between Performance Data Helpers and Performance Data from perflib
Any PerfData custom metrics can be implement now, without having the hard requirement of implement collector of each single subsystem.
Example:
Produces this:
Details
In case it works well, some collectors will be migrate from perflib to PDH, too.