Enable the use of remote ip addresses in Windows Firewall exception #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @siku4! |
Signed-off-by: siku4 <[email protected]>
siku4
force-pushed
the
add-firewall-remoteaddress-option-to-installer
branch
from
e414577
to
2ebea42
Compare
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…emoteaddress-option-to-installer Enable the use of remote ip addresses in Windows Firewall exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a way to limit the Windows Firewall exception (added by the installer) to the remote IP address of our prometheus server to prevent uninvolved systems from accessing the metrics endpoint. This could also be of interest to other users who want to roll out windows_exporter on a large number of machines (e.g. SCCM).
I've never used WiX before but found the
<fw:RemoteAddress>tag and added a CLI property. I have successfully tested the following cases:msiexec /i <path-to-msi-file> REMOTE_ADDR=<ip-address-1>: Adds one IP address toRemote IP addressin FW rulemsiexec /i <path-to-msi-file> REMOTE_ADDR=<ip-address-1>,<ip-address-2>: Adds two IP addresses toRemote IP addressin FW rulemsiexec /i <path-to-msi-file>: Leaves the optionAny IP addressactivated