Rename mssql instance label to mssql_instance #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instance label is conflicting with default Prometheus "instance" label which is added when scraping targets. Signed-off-by: Ben Reedy <[email protected]>
carlpett
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
Yikes, how did I miss that in the reviews? 😮 Interesting as well that there haven't been any reports, I suspect people aren't setting honor_labels: true very often and simply accept the exported_ prefix Prometheus adds.
Anyway, this is the right thing to do. Not a huge fan of the new label name either, but I dont' have a better suggestion.
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
Rename mssql instance label to mssql_instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance label is conflicting with default Prometheus "instance" label
which is added when scraping targets.
Resolves #690