Add HTTPS configuration

[SuperQ]

Add the exporter-toolkit https package to allow configuring TLS and
auth.

Signed-off-by: Ben Kochie [email protected]

[SuperQ]

Simplified version of #680

[carlpett]

I wonder why the promu logs don't seem to output the actual errors in builds on AppVeyor... Anyway, the build fails because of an undefined variable (logger), which I guess was left as a TODO to integrate?

[replay]

the build fails because of an undefined variable (logger), which I guess was left as a TODO to integrate?

I think the issue is that https.Listen() requires a go-kit logger, but the windows exporter currently uses logrus (via github.com/prometheus/common/log).

So we'd have to either replace the logger used by the windows_exporter and make it use go-kit everywhere, or we just instantiate a go-kit logger to pass into https.Listen() which means we'll end up with mixed loggers.

[carlpett]

So, PR is updated with working logging. I also took this opportunity to copy common/log into a new package log in the exporter, as discussed previously @breed808.

[replay]

So, PR is updated with working logging. I also took this opportunity to copy common/log into a new package log in the exporter, as discussed previously @breed808.

Thanks a lot @carlpett for implementing that 👍.
I'd be happy to review it, unfortunately my approval won't be sufficient to merge this PR as far as I understand.

[breed808]

I've tested this with a self-signed CA and certificate, and it's looking good 👍
Do we want additional testing or review on this change?

[carlpett]

Whoops, missed the response! Yeah, my testing looked good as well, so I think we can get it out there for some feedback. It's marked as experimental, after all.
I can't approve PRs I've contributed to though, so if you think it looks good I'll need a thumbs up there 🙂

[hartman17]

We are willing to test this on a larger scale once it's merged and a release is cut. Providing any feedback/issues we encounter.

[breed808]

I can't approve PRs I've contributed to

I wasn't aware of this limitation, but it makes sense. PR looks good to me 👍