Set container collector prefix based on owner property #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
container_id
label for the metrics reported by the container collector to use the owner ref which is set by docker and containerd respectively.When running the windows_exporter with the
container
collector running with a containerd runtime the output of the metrics prefixes the metricscontainer_id
label withdocker://
but it should becontainerd://
to match other tooling.Current output:
If you use hcsdiag list on the host to see the owner ref it specifies the containerd shim as the owner:
This is important for jobs that match against
container_id
to gather more stats from tools likekube-state-metrics
which specifiescontainerd
for thecontianerid
:For example, a promethues rule from the kubernetes-mixin project: