Add benchmark for each collector #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good from a code point of view, just wondering if we would intend to run these as part of CI or more ad-hoc? |
|
My intention was for these to be run in an ad-hoc manner, primarily to detect slow collectors. We could integrate these into the CI with cob. If you're interested I can get that working too. |
|
I think having them available for ad-hoc usage is sufficient for now. The build agents don't have all the services installed anyway. |
carlpett
approved these changes
Mar 28, 2021
Benchmarks will allow for easier identification of slow collectors. Additionally, they increase test coverage of the collectors, with some collectors now reaching 80-95% coverage with this change. Collector benchmarks have been structed so that common functionality is present in `collector/collector_test.go` as is done with non-test functionality in `collector/collector.go`. Test logic that is specific to individual collectors is present in the collector test file (E.G. `collector/process_test.go` for the Process collector). Signed-off-by: Ben Reedy <[email protected]>
|
FYI I've rebased this to resolve the merge conflicts introduced by #702. There's no functional difference in the change so I'll proceed with the merge. |
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
Add benchmark for each collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks will allow for easier identification of slow collectors.
Additionally, they increase test coverage of the collectors, with some
collectors now reaching 80-95% coverage with this change.
Collector benchmarks have been structed so that common functionality is
present in
collector/collector_test.goas is done with non-testfunctionality in
collector/collector.go.Test logic that is specific to individual collectors is present in the
collector test file (E.G.
collector/process_test.gofor the Processcollector).
Signed-off-by: Ben Reedy [email protected]