Add support for MSCluster collectors

[sstorie]

Using the provided collector I added a few new collectors to grab information from Microsoft Clusters using the MSCluster WMI objects.

I'm not a Go programmer, so there's likely a more elegant way to handle this in a single file, but wanted to submit for some initial feedback.

[sstorie]

I meant to say "Using the provided collector-generator" in my initial comment.

[breed808]

Thanks for submitting this!

I've briefly reviewed the changes and have left a few comments on the mscluster_network collector, which are applicable to the other collectors.

You'll also want to create entries for the collectors in the docs/ directory. Copying one of the existing markdown files might be easiest.

Let me know if any clarification or help is needed.

[breed808]

Thanks for the update Sam! I think you'll need to drop the commit with the go.mod and go.sum changes (or rebase your branch on master), as this has introduced a merge conflict. The cluster collectors aren't introducing new dependencies so the changes won't be required.

Once the metric & collector documentation has been added this should be good to merge 👍

[sstorie]

Ok, haven't lost sight of this but with the US holidays I haven't had any time to spend here. I appreciate the feedback and will work to get you an update.

[sstorie]

Thanks for the update Sam! I think you'll need to drop the commit with the go.mod and go.sum changes (or rebase your branch on master), as this has introduced a merge conflict. The cluster collectors aren't introducing new dependencies so the changes won't be required.

Once the metric & collector documentation has been added this should be good to merge 👍

I've got 2 of the 5 collectors updated with docs. Will keep plugging away over the next day or two and wrap this up.

[sstorie]

I think I have everything in there and ready to go. Please let me know if you desire any other changes, or need the commits cleaned up somehow.

[breed808]

Thanks Sam, this is looking good!

One last thing, could you add the cluster collectors as entries in the README.md collector list, with the documentation links?

[sstorie]

Thanks Sam, this is looking good!

One last thing, could you add the cluster collectors as entries in the README.md collector list, with the documentation links?

Done.

[sstorie]

Just to confirm - and I understand this may not be the highest priority - I am not aware of any other work being asked for here before accepting the merge. If there's something more expected on my end please let me know.

I may have caused an issue seeing or resolving the changes because of how I worked through the DCO process - my apologies if that's the case.

[breed808]

Apologies for the delay Sam, I've been pretty busy with work recently and haven't been able to get back to this.

The CI test job is failing due to a bug in the build tool installation command, which I've raised a PR to fix.
Once that's merged I'll re-run the CI for this PR and get it merged.

[breed808]

@sstorie could you rebase this PR on master and push? The CI fix has been merged but needs to be present in your feature branch.

[jpatigny]

hey guys, any update on this ?
I'd love to have this feature.

@sstorie would you be able to do the rebase or do you want someone else to care of it ?

[breed808]

I rebased and force pushed the branch. @sstorie if you have any local changes, rebase them onto master and force push to overwrite my changes.

[sstorie]

No I don't have any local changes, and thank you for taking the initiative to get this pulled in.

[breed808]

The DCO check isn't happy, likely due to the nature of the rebase. I'll force a merge as all other checks have passed.