Fix and update golanci-lint reported issues #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Trangoni <[email protected]>
See, ``` collector/os.go:306:10: unnecessary conversion (unconvert) float64(fsipf), ^ ``` Signed-off-by: Mario Trangoni <[email protected]>
See, ``` $ codespell --skip=".git,./vendor" --ignore-words-list=calle ./exporter.go:262: overriden ==> overridden ./collector/dfsr.go:132: receieved ==> received ./collector/dns.go:140: reponses ==> responses ./collector/exchange.go:238: occational ==> occasional ./collector/mssql.go:1961: shoud ==> should ./collector/process.go:137: sharable ==> shareable ./collector/remote_fx.go:64: seccond ==> second ./docs/collector.dfsr.md:47: fils ==> fills, files, file ./docs/collector.exchange.md:39: lengt ==> length ./docs/collector.fsrmquota.md:3: Ressource ==> Resource ./docs/collector.fsrmquota.md:51: Ressource ==> Resource ./docs/collector.os.md:20: sotred ==> sorted, stored ./docs/collector.process.md:56: sharable ==> shareable ./docs/collector.smtp.md:27: mailformed ==> malformed ``` Signed-off-by: Mario Trangoni <[email protected]>
See, ``` $ GOOS=windows GOARCH=amd64 golangci-lint run ./... 2>1 | grep var-declaration collector/os.go:205:22: var-declaration: should drop = 0 from declaration of var fsipf; it is the zero value (revive) collector/os.go:226:23: var-declaration: should drop = 0 from declaration of var pfbRaw; it is the zero value (revive) ``` Signed-off-by: Mario Trangoni <[email protected]>
See,
```
log/gokit_adapter.go:9:26: unexported-return: exported func NewToolkitAdapter returns unexported type *log.logAdapter, which can be annoying to use (revive)
func NewToolkitAdapter() *logAdapter {
^
```
Signed-off-by: Mario Trangoni <[email protected]>
…nt to v1.43.0 Signed-off-by: Mario Trangoni <[email protected]>
breed808
approved these changes
Dec 25, 2021
mjtrangoni
added a commit
to mjtrangoni/windows_exporter
that referenced
this pull request
Dec 29, 2021
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
mjtrangoni
added a commit
to mjtrangoni/windows_exporter
that referenced
this pull request
Jan 2, 2022
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
akrauza
pushed a commit
to akrauza/windows_exporter
that referenced
this pull request
Jan 4, 2022
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
jsturtevant
pushed a commit
to jsturtevant/windows_exporter
that referenced
this pull request
Jan 10, 2022
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
mansikulkarni96
pushed a commit
to mansikulkarni96/prometheus-community-windows_exporter
that referenced
this pull request
Jul 7, 2022
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
mansikulkarni96
pushed a commit
to mansikulkarni96/prometheus-community-windows_exporter
that referenced
this pull request
Jul 7, 2022
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…ci-lint Fix and update golanci-lint reported issues
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
After fixing all spelling issues in prometheus-community#892, this will prevent us for adding new ones. Signed-off-by: Mario Trangoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlpett @breed808,
First of all, thank you for this project!
This PR update golangci-lint to the latest version, replacing some deprecated linters from the configuration file. Also took the opportunity to fix some spelling issues detected by codespell, which could be added to the CI in a future.
Note that go1.17 was used so this adds the new go command format changes, see go-command.