-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collector for Active Directory Certificate Services (ADCS) #895
Conversation
54fb672
to
53b8275
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this Austin! I'm not able to test the collector myself at the moment, but I've left a few queries regarding the metric descriptions and a few other minor issues.
Let me know if any clarification is needed.
@breed808 Hey Ben! Thanks for the feedback on the above. Made the changes as requested. Let me know how it looks :) Here is a screenshot of the exporter running with the above changes on a Server 2012 machine along side PerfMon: |
Thanks Austin, I've closed all but one of the comment threads. Once the metric names/descriptions are in order, you'll then need to update the collector documentation. At the end we might need to squash or rebase the commits to keep the history tidy, but that's more a nitpick than an issue. |
Signed-off-by: Austin D. Krauza <[email protected]>
Hey @breed808 ! Thank you for your help and review. I updated the documentation and squashed the commit down into one commit message of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for making those amendments Austin 👍
Add Collector for Active Directory Certificate Services (ADCS)
No description provided.