This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Add filtering on ref of samples and tombstones in checkpoint.go #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: naivewong <[email protected]>
Signed-off-by: naivewong <[email protected]>
|
this will decrease performance, but it is the correct behaviour. LGTM ping @gouthamve , @codesome , @bwplotka |
|
btw @naivewong don't forget that tomorrow (the 9th) is the last day for the GSOC proposal submissions. Feel free to ping me on IRC with yours so I can give some feedback before submitting. |
|
This will lead to data being silently missing for the wal watcher, this change should not be accepted. |
|
after some IRC discussions the correct behaviour is to keep all series references until the last segment has samples referencing these. closing this PR in favour of the correct fix in #577 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/prometheus/tsdb/blob/db9177de0cc7fec169bda0ede005ffd6d6fd1d80/checkpoint.go#L102
As title, I think
keepfunction should also be applied on samples and tombstones.