jsonnet: include rewritten kubernetes-grafana library #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
force-pushed
the
grafana-refactor
branch
from
cc5cefb
to
a835f3c
Compare
paulfantom
force-pushed
the
grafana-refactor
branch
from
a835f3c
to
5277118
Compare
|
This won't work in CI until brancz/kubernetes-grafana#117 is completed. |
This was referenced Oct 21, 2021
paulfantom
force-pushed
the
grafana-refactor
branch
from
5277118
to
6aa6b78
Compare
|
As brancz/kubernetes-grafana#117 was merged, we need this PR to keep up :) |
paulfantom
commented
Oct 21, 2021
| @@ -39,7 +39,7 @@ local utils = import './lib/utils.libsonnet'; | |||
| images: { | |||
| alertmanager: 'quay.io/prometheus/alertmanager:v' + $.values.common.versions.alertmanager, | |||
| blackboxExporter: 'quay.io/prometheus/blackbox-exporter:v' + $.values.common.versions.blackboxExporter, | |||
| grafana: 'grafana/grafana:v' + $.values.common.versions.grafana, | |||
| grafana: 'grafana/grafana:' + $.values.common.versions.grafana, | |||
There was a problem hiding this comment.
It is weird how noone reported this bug 🤔
There was a problem hiding this comment.
Well, we do have tests for grafana's deployment right? We would have caught if that was a real problem 🕵️
There was a problem hiding this comment.
The problem is that such image does not exist, so pod should error out. 🤷
ArthurSens
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Include brancz/kubernetes-grafana#117
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.