Explicitly declare allowPrivilegeEscalation to false in all components #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
reviewed
Jan 24, 2022
| @@ -118,6 +118,8 @@ function(params) (import 'github.com/kubernetes/kube-state-metrics/jsonnet/kube- | |||
| image: ksm._config.kubeRbacProxyImage, | |||
| }), | |||
|
|
|||
| // The override adding 'allowPrivilegeEscalation: false' can be deleted when | |||
There was a problem hiding this comment.
Suggested change
| // The override adding 'allowPrivilegeEscalation: false' can be deleted when | |
| // FIXME(ArthurSens): The override adding 'allowPrivilegeEscalation: false' can be deleted when |
nit: Let's just add FIXME so it is easier to spot later ;)
paulfantom
reviewed
Jan 24, 2022
| @@ -83,4 +83,20 @@ function(params) | |||
| }], | |||
| }, | |||
| }, | |||
|
|
|||
| // The override adding 'allowPrivilegeEscalation: false' can be deleted when | |||
There was a problem hiding this comment.
Suggested change
| // The override adding 'allowPrivilegeEscalation: false' can be deleted when | |
| // FIXME(ArthurSens): The override adding 'allowPrivilegeEscalation: false' can be deleted when |
nit: Let's just add FIXME so it is easier to spot later ;)
paulfantom
approved these changes
Jan 24, 2022
Although containers that do not run as privileged already have this set to false by kubernetes Kubespace [asks us](https://hub.armo.cloud/docs/c-0016) to explicitly declare it to false where not needed. Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: GitHub <[email protected]>
ArthurSens
force-pushed
the
as/forbid-privilege-scalation
branch
from
867eb8d
to
2d02121
Compare
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looking at Kubernetes docs, if a container isn't running as privileged and don't have
CAP_SYS_ADMINcapabilities, then Kubernetes already sets theallowPrivilegeEscalationto false by default.Kubescape asks us to explicitly declare it false anyway, I believe the intention is to future-guard against the kubernetes behavior changes for some reason.
I've run kube-prometheus from this PR in kind, the whole stack was able to run smoothly without errors. Metrics are getting collected and scraped without problems as well.
The only thing I haven't tested by hand was the privileged blackbox-exporter since I don't use it, personally.
Fixes #1588
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.