Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed CAP_ from node-exporter daemonset #1647

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Removed CAP_ from node-exporter daemonset #1647

merged 1 commit into from
Feb 16, 2022

Conversation

fullmetalrooster
Copy link
Contributor

Description

This fixes the node-exporter daemonset which had also the CAP_ prefix which is not expected by Kubernetes according the this documentation.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.
removed the CAP_ prefix from node-exporter daemonset capabilites

- removed the CAP_ prefix from node-exporter daemonset capabilites

@fullmetalrooster fullmetalrooster changed the title removed CAP_ from node-exporter daemonset Removed CAP_ from node-exporter daemonset Feb 16, 2022
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the fix!

Context for others, we're rolling the latest changes to our clusters and discovering some bugs here and there 😅

@ArthurSens ArthurSens merged commit 3f1323d into prometheus-operator:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants