Add 1.19.0 changelog #1451
Add 1.19.0 changelog #1451
Conversation
Signed-off-by: Arthur Silva Sens <[email protected]>
|
Once this is done, I can mark the Version function in |
| @@ -1,5 +1,12 @@ | |||
| ## Unreleased | |||
|
|
|||
| ## 1.19.0 / 2023-02-27 | |||
|
|
|||
| The module `prometheus/common v0.48.0` introduced a bug when used together with client_golang. If your project uses client_golang and you want to use `prometheus/common v0.48.0` or higher, please update client_golang to v1.19.0. | |||
There was a problem hiding this comment.
Personally I find this frustrating, because I can't figure out what the bug is,
even after reading the full list of commits between 1.18 and 1.19.
Could you give a hint?
There was a problem hiding this comment.
A few constants ceased to exist (or were made private) in common 0.48.0, client_golang would break when trying to access those constants.
The fix was done here: #1448
There was a problem hiding this comment.
and now that you mention I totally agree that this text could be clearer, I'm just not sure if users are interested in such explanation "constant values could not be accessed anymore" 🤔
There was a problem hiding this comment.
Thanks, linking to the fix is enough information to trace it through.
I would say the root of the thing is prometheus/common#576; some constants were deliberately hidden. I would use the word "incompatibility" rather than "bug".
There was a problem hiding this comment.
We still haven't merged release-1.19 back to main, so I've raised #1454 and we can get it rephrased :)
No description provided.