This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Integrate lezer-promql v0.19.0 with alternative top #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Husson <[email protected]>
Signed-off-by: Augustin Husson <[email protected]>
Signed-off-by: Augustin Husson <[email protected]>
Signed-off-by: Augustin Husson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 72.72% 72.40% -0.33%
==========================================
Files 15 15
Lines 748 750 +2
Branches 167 167
==========================================
- Hits 544 543 -1
- Misses 125 129 +4
+ Partials 79 78 -1
Continue to review full report at Codecov.
|
juliusv
reviewed
May 19, 2021
juliusv
reviewed
May 19, 2021
Signed-off-by: Augustin Husson <[email protected]>
Signed-off-by: Augustin Husson <[email protected]>
Nexucis
force-pushed
the
feature/integrate-alternative-tops
branch
from
e736c31
to
5804c31
Compare
Signed-off-by: Augustin Husson <[email protected]>
juliusv
reviewed
May 20, 2021
src/app/app.html
Outdated
| @@ -34,6 +34,12 @@ <h3>CodeMirror Mode PromQL</h3> | |||
| <option selected value="offline">Offline</option> | |||
| <option value="prometheus">Prometheus</option> | |||
| </select> | |||
| <br> | |||
| <label for="fullLanguage">Language to complete</label> | |||
There was a problem hiding this comment.
I guess this and the line below now also shouldn't say fullLanguage / fullPromQLLanguage anymore, but something like languageType.
|
👍 besides comment |
Signed-off-by: Augustin Husson <[email protected]>
|
thanks for the review @juliusv ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.