Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expfmt: Add UTF-8 syntax support in text_parse.go #670

Merged
merged 17 commits into from
Aug 21, 2024

Conversation

fedetorres93
Copy link
Contributor

@fedetorres93 fedetorres93 commented Jul 31, 2024

This PR adds support for the new UTF-8 syntax proposed here.

Main changes:

  • Metric names may include UTF-8 characters and, if so, they will be quoted and inside brackets, without an operator (for example: {"my.metric", label="value"} 1)
  • Label names may include UTF-8 characters and, if so, they will be quoted (for example: {"my.metric", "my.label"="value"} 1)

Addresses #554

Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
Signed-off-by: Federico Torres <[email protected]>
@fedetorres93 fedetorres93 marked this pull request as ready for review August 2, 2024 17:27
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@ywwg mentioning you here in case you haven't seen it. You are probably more qualified to review this than me.

p.parseError(fmt.Sprintf("unexpected end of metric value %q", p.currentByte))
return nil
}
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code paths in the if clause above end up returning, so we don't need the else here.

@@ -60,6 +60,7 @@ type TextParser struct {
currentMF *dto.MetricFamily
currentMetric *dto.Metric
currentLabelPair *dto.LabelPair
currentLabel []*dto.LabelPair
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that protobuf uses the singular even for repeated messages. But maybe it would still make more sense and be more readable to use the plural here? currentLabels collides with the map of the same name below, but maybe call this currentLabelPairs? Also, is there a good comment to add here to explain what this variable is for? (cf. the comment for the currentLabels variable below).

@@ -385,6 +385,159 @@ request_duration_microseconds_count 2693
},
},
},
// 5: UTF-8 counter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This should end with a period to be consistent with the naming above.

More substantially: Let's be more explicit here about what's significant. It's not special that this is a counter, and "UTF-8" per se doesn't say anything (the old metric names were all valid UTF-8, too). How about "Quoted metric name and quoted label name with dots."?

},
},
},
// 6: Dots in name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "Metric family with dots in name."

},
},
},
// 6: Dots in name, no labels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, end with period.

},
},
},
// 7: Gauge, UTF-8, +Inf as value, multi-byte characters in label values.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, "gauge" is not important. Say something about the special character rather than just stating "UTF-8".

},
},
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more test cases. Ideas:

  • Various escaped special characters in a label name and a metric name (like \", but also including multi-line with \n).
  • The name is not the first element: {foo="bar", "late.name"}.

It would be good to also add a few more cases to testTextParseError, e.g. multiple metric names like {"one.name", "another.name"}.

@fedetorres93
Copy link
Contributor Author

@beorn7 Thank you for your review. All feedback has been addressed.

Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ywwg do you want to give it a final look?

Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you run code coverage on this to make sure the major branches are covered? Unless something is missing, lgtm

Signed-off-by: Federico Torres <[email protected]>
@fedetorres93
Copy link
Contributor Author

have you run code coverage on this to make sure the major branches are covered? Unless something is missing, lgtm

Most branches were covered, but I added a couple more tests to cover additional error cases.

Copy link
Member

@ywwg ywwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the last tests! lgtm

@beorn7
Copy link
Member

beorn7 commented Aug 21, 2024

Thank you both. I'll squash this because we have quite a few mini commits in here.

@beorn7 beorn7 merged commit 8968b6c into prometheus:main Aug 21, 2024
7 checks passed
XSAM referenced this pull request in XSAM/otelsql Aug 27, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.55.0` -> `v0.56.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0)

#### What's Changed

- Don't always fetch a OAuth2 token, if the secret from a file didn't
change by [@&#8203;multani](https://togithub.com/multani) in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- remove dependency to github.com/prometheus/client_golang by
[@&#8203;ilius](https://togithub.com/ilius) in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664)
- Revert
[#&#8203;576](https://togithub.com/prometheus/common/issues/576) and add
deprecation notice by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665)
- Bump golang.org/x/net from 0.26.0 to 0.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667)
- use basic string in IsValidLegacyMetricName by
[@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674)
- Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671)
- sigv4: support nil body by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673)
- Fix overflows of untyped int constants on 32-bit by
[@&#8203;dswarbrick](https://togithub.com/dswarbrick) in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- Update client_golang by [@&#8203;SuperQ](https://togithub.com/SuperQ)
in
[https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676)
- Update golangci lint by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679)
- expfmt: Add UTF-8 syntax support in text_parse.go by
[@&#8203;fedetorres93](https://togithub.com/fedetorres93) in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681)
- fix(utf8): provide a method for explicitly checking label names for
legacy validity by [@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682)

#### New Contributors

- [@&#8203;multani](https://togithub.com/multani) made their first
contribution in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- [@&#8203;ilius](https://togithub.com/ilius) made their first
contribution in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- [@&#8203;dswarbrick](https://togithub.com/dswarbrick) made their first
contribution in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- [@&#8203;fedetorres93](https://togithub.com/fedetorres93) made their
first contribution in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)

**Full Changelog**:
prometheus/common@v0.55.0...v0.56.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/XSAM/otelsql).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten referenced this pull request in open-telemetry/opentelemetry-collector Aug 28, 2024
)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.55.0` -> `v0.56.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0)

#### What's Changed

- Don't always fetch a OAuth2 token, if the secret from a file didn't
change by [@&#8203;multani](https://togithub.com/multani) in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- remove dependency to github.com/prometheus/client_golang by
[@&#8203;ilius](https://togithub.com/ilius) in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664)
- Revert
[#&#8203;576](https://togithub.com/prometheus/common/issues/576) and add
deprecation notice by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665)
- Bump golang.org/x/net from 0.26.0 to 0.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667)
- use basic string in IsValidLegacyMetricName by
[@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674)
- Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671)
- sigv4: support nil body by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673)
- Fix overflows of untyped int constants on 32-bit by
[@&#8203;dswarbrick](https://togithub.com/dswarbrick) in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- Update client_golang by [@&#8203;SuperQ](https://togithub.com/SuperQ)
in
[https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676)
- Update golangci lint by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679)
- expfmt: Add UTF-8 syntax support in text_parse.go by
[@&#8203;fedetorres93](https://togithub.com/fedetorres93) in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681)
- fix(utf8): provide a method for explicitly checking label names for
legacy validity by [@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682)

#### New Contributors

- [@&#8203;multani](https://togithub.com/multani) made their first
contribution in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- [@&#8203;ilius](https://togithub.com/ilius) made their first
contribution in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- [@&#8203;dswarbrick](https://togithub.com/dswarbrick) made their first
contribution in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- [@&#8203;fedetorres93](https://togithub.com/fedetorres93) made their
first contribution in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)

**Full Changelog**:
prometheus/common@v0.55.0...v0.56.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
MrAlias referenced this pull request in open-telemetry/opentelemetry-go-contrib Aug 29, 2024
…6059)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.55.0` -> `v0.57.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0)

#### What's Changed

- feat: new promslog and promslog/flag packages to wrap log/slog by
[@&#8203;tjhop](https://togithub.com/tjhop) in
[https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677)

#### New Contributors

- [@&#8203;tjhop](https://togithub.com/tjhop) made their first
contribution in
[https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677)

**Full Changelog**:
prometheus/common@v0.56.0...v0.57.0

###
[`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0)

#### What's Changed

- Don't always fetch a OAuth2 token, if the secret from a file didn't
change by [@&#8203;multani](https://togithub.com/multani) in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- remove dependency to github.com/prometheus/client_golang by
[@&#8203;ilius](https://togithub.com/ilius) in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664)
- Revert
[#&#8203;576](https://togithub.com/prometheus/common/issues/576) and add
deprecation notice by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665)
- Bump golang.org/x/net from 0.26.0 to 0.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667)
- use basic string in IsValidLegacyMetricName by
[@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674)
- Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671)
- sigv4: support nil body by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673)
- Fix overflows of untyped int constants on 32-bit by
[@&#8203;dswarbrick](https://togithub.com/dswarbrick) in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- Update client_golang by [@&#8203;SuperQ](https://togithub.com/SuperQ)
in
[https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676)
- Update golangci lint by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679)
- expfmt: Add UTF-8 syntax support in text_parse.go by
[@&#8203;fedetorres93](https://togithub.com/fedetorres93) in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681)
- fix(utf8): provide a method for explicitly checking label names for
legacy validity by [@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682)

#### New Contributors

- [@&#8203;multani](https://togithub.com/multani) made their first
contribution in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- [@&#8203;ilius](https://togithub.com/ilius) made their first
contribution in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- [@&#8203;dswarbrick](https://togithub.com/dswarbrick) made their first
contribution in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- [@&#8203;fedetorres93](https://togithub.com/fedetorres93) made their
first contribution in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)

**Full Changelog**:
prometheus/common@v0.55.0...v0.56.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias referenced this pull request in open-telemetry/opentelemetry-go Aug 29, 2024
…5748)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.55.0` -> `v0.57.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0)

#### What's Changed

- feat: new promslog and promslog/flag packages to wrap log/slog by
[@&#8203;tjhop](https://togithub.com/tjhop) in
[https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677)

#### New Contributors

- [@&#8203;tjhop](https://togithub.com/tjhop) made their first
contribution in
[https://github.com/prometheus/common/pull/677](https://togithub.com/prometheus/common/pull/677)

**Full Changelog**:
prometheus/common@v0.56.0...v0.57.0

###
[`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0)

#### What's Changed

- Don't always fetch a OAuth2 token, if the secret from a file didn't
change by [@&#8203;multani](https://togithub.com/multani) in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- remove dependency to github.com/prometheus/client_golang by
[@&#8203;ilius](https://togithub.com/ilius) in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/661](https://togithub.com/prometheus/common/pull/661)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/664](https://togithub.com/prometheus/common/pull/664)
- Revert
[#&#8203;576](https://togithub.com/prometheus/common/issues/576) and add
deprecation notice by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/665](https://togithub.com/prometheus/common/pull/665)
- Bump golang.org/x/net from 0.26.0 to 0.27.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/667](https://togithub.com/prometheus/common/pull/667)
- use basic string in IsValidLegacyMetricName by
[@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/668](https://togithub.com/prometheus/common/pull/668)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/672](https://togithub.com/prometheus/common/pull/672)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/674](https://togithub.com/prometheus/common/pull/674)
- Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/prometheus/common/pull/671](https://togithub.com/prometheus/common/pull/671)
- sigv4: support nil body by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/673](https://togithub.com/prometheus/common/pull/673)
- Fix overflows of untyped int constants on 32-bit by
[@&#8203;dswarbrick](https://togithub.com/dswarbrick) in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- Update client_golang by [@&#8203;SuperQ](https://togithub.com/SuperQ)
in
[https://github.com/prometheus/common/pull/676](https://togithub.com/prometheus/common/pull/676)
- Update golangci lint by
[@&#8203;roidelapluie](https://togithub.com/roidelapluie) in
[https://github.com/prometheus/common/pull/679](https://togithub.com/prometheus/common/pull/679)
- expfmt: Add UTF-8 syntax support in text_parse.go by
[@&#8203;fedetorres93](https://togithub.com/fedetorres93) in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)
- Synchronize common files from prometheus/prometheus by
[@&#8203;prombot](https://togithub.com/prombot) in
[https://github.com/prometheus/common/pull/681](https://togithub.com/prometheus/common/pull/681)
- fix(utf8): provide a method for explicitly checking label names for
legacy validity by [@&#8203;ywwg](https://togithub.com/ywwg) in
[https://github.com/prometheus/common/pull/682](https://togithub.com/prometheus/common/pull/682)

#### New Contributors

- [@&#8203;multani](https://togithub.com/multani) made their first
contribution in
[https://github.com/prometheus/common/pull/647](https://togithub.com/prometheus/common/pull/647)
- [@&#8203;ilius](https://togithub.com/ilius) made their first
contribution in
[https://github.com/prometheus/common/pull/662](https://togithub.com/prometheus/common/pull/662)
- [@&#8203;dswarbrick](https://togithub.com/dswarbrick) made their first
contribution in
[https://github.com/prometheus/common/pull/675](https://togithub.com/prometheus/common/pull/675)
- [@&#8203;fedetorres93](https://togithub.com/fedetorres93) made their
first contribution in
[https://github.com/prometheus/common/pull/670](https://togithub.com/prometheus/common/pull/670)

**Full Changelog**:
prometheus/common@v0.55.0...v0.56.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-go).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants