-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update macOS SDK to 14 #239
Conversation
I think the issue is that we can't build a cross-compiling package that will work in our docker image without uploading and using the SDK as we're currently using it. |
493ba15
to
4d5646e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good. Just need to also update 1.20.
Signed-off-by: Alper Polat <[email protected]> Revert back to using secret URL Signed-off-by: Alper Polat <[email protected]> Add && back Signed-off-by: Alper Polat <[email protected]> Remove useless copy Signed-off-by: Alper Polat <[email protected]> Put JOBS back to 2 Signed-off-by: Alper Polat <[email protected]> Update 1.20 as well Signed-off-by: Alper Polat <[email protected]>
Updated 1.20 too and squashed. |
I tested this manually on my system and it seems to build and run fine. I don't have an arm64 mac to test with. |
I could not make it work on my arm64 mac:
|
@SuperQ previously stated that we need to update the xcode stuff in
golang-builder
image:prometheus/node_exporter#2539 (comment)
So, I've attempted to do that. More below:
What I've done
14
PROM_OSX_SDK_URL
secret, I used my local copy of macOS SDK (Not committed to repo) >> This will fail the CircleCI pipelineJOBS
to4
to make compilation fastergolang-builder
image with updated macOS SDK, didn't change tagging (resulting tag wasquay.io/prometheus/golang-builder:1.21.5-main-master
) (Not yet committed to quay.io!)Questions
Notes
Xcode license agreement says
and
My interpretation is that we are able to develop, and distribute using macOS SDK.
But, the catch was right at the start:
In this case, I feel like we should stay in the safe side and build it on macOS machine, as CircleCI already offers those.
To do (My plan)
PROM_OSX_SDK_URL
, or change the way SDK is injected into the docker imageJOBS
back to what it was, and putPROM_OSX_SDK_URL
stuff back to what it was if we won't change the injection method)Feel free to add more comments and info as you see fit.
Thanks!