Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check-config flag #146

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

glightfoot
Copy link
Contributor

Fixes #31

@matthiasr

Signed-off-by: glightfoot [email protected]

Signed-off-by: glightfoot <[email protected]>
@roidelapluie
Copy link
Member

thanks! #145 would add a getool cmd line, which we could reuse for this?

@matthiasr
Copy link
Contributor

:why_not_both: 😁

In general I agree that if there is a tool, it should support config checking. The --check-config flag is in line with the statsd exporter (that doesn't have a tool yet). We can also change it again later, "replace graphite_exporter --check-config with getool check config" is a kind of breaking change that I am not afraid to make.

@matthiasr matthiasr merged commit 6651ccc into prometheus:master Feb 19, 2021
matthiasr added a commit that referenced this pull request Feb 19, 2021
Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping configuration check
3 participants