strings.TrimRight is used instead of TrimSuffix #507
Comments
|
Oops, thanks! Wanna submit a quick PR to fix this? |
rexagod
added a commit
to rexagod/procfs
that referenced
this issue
Mar 21, 2024
Use `TrimSuffix` instead of `TrimRight` in cases where an exact suffix string needs to be removed, not all occurrences of all characters in a specified cutset. Fixes: prometheus#507 Signed-off-by: Pranshu Srivastava <[email protected]>
SuperQ
pushed a commit
that referenced
this issue
May 12, 2024
Use `TrimSuffix` instead of `TrimRight` in cases where an exact suffix string needs to be removed, not all occurrences of all characters in a specified cutset. Fixes: #507 Signed-off-by: Pranshu Srivastava <[email protected]>
jritter
pushed a commit
to jritter/procfs
that referenced
this issue
Jul 15, 2024
Use `TrimSuffix` instead of `TrimRight` in cases where an exact suffix string needs to be removed, not all occurrences of all characters in a specified cutset. Fixes: prometheus#507 Signed-off-by: Pranshu Srivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This line aims to remove " kB" suffix, but instead removes all characters from " kB" cutset.
procfs/proc_smaps.go
Line 130 in cdc4512
Similar fix as was done in this commit is required - b3d77ec .
The text was updated successfully, but these errors were encountered: