Unify error messages and prepare to adopt wrapping error messages, part 2 #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](golang/sys@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: conall <[email protected]>
and MountError Signed-off-by: conall <[email protected]>
…riables - Include original err whenever raising an exception Signed-off-by: conall <[email protected]>
issue was found by Svace static analyzer (https://www.ispras.ru/en/technologies/svace/) Signed-off-by: Artem Seleznev <[email protected]> Signed-off-by: conall <[email protected]>
Can be used by other projects (eg node_exporter) to read a single sysfs file rather than all of them at once, which can cause lock contention in the kernel as many sysfs net files grab the RTNL lock. Signed-off-by: Dan Williams <[email protected]> Signed-off-by: conall <[email protected]>
Modernised method of fetching mdraid statistics via machine-readable sysfs entries, instead of parsing human-readable /proc/mdstat. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: conall <[email protected]>
Signed-off-by: shankeerthan-kasilingam <[email protected]> Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
… and cpuinfo.go Signed-off-by: conall <[email protected]>
fscache.go Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Move the file hadling into the parseNetstat() function to only open one file at a time. This eliminates keeping all files open until all are read. Signed-off-by: SuperQ <[email protected]> Signed-off-by: conall <[email protected]>
mountstats.go Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
and net_ip_socket.go Signed-off-by: conall <[email protected]>
fmt.Errorf() atoms when there is no err to wrap Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
fmt.Errorf() is only available in Go v1.20+ https://go.dev/doc/go1.20#errors Signed-off-by: conall <[email protected]>
Signed-off-by: conall <[email protected]>
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Conall O'Brien <[email protected]>
Signed-off-by: Conall O'Brien <[email protected]>
Signed-off-by: Conall O'Brien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of an implementation for #358