-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chip to the DRM parser class #672
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Deezzir <[email protected]>
Signed-off-by: Deezzir <[email protected]>
2b6737d
to
3705157
Compare
Signed-off-by: Deezzir <[email protected]>
Signed-off-by: Deezzir <[email protected]>
Signed-off-by: Deezzir <[email protected]>
@discordianfish and @SuperQ please review! Thank you |
HWmonChip string // The hwmon chip. | ||
} | ||
|
||
func cleanChipName(name string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to sanitize the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's something that the hwmon does with the chip names as well, so the format is similar.
Adds a chip label to the
DRM
parser class so the data can be related tohwmon
metrics when exported by the node_exporter.For example,
node_exporter
produces the following metric:So, by having a
chip
label coming from the DRM parser, DRM metrics can be related to hwmon sensor metrics to build a better dashboard with clear AMD GPU filters.For example:
Also closes: #673