resolve race condition in maxGauge #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Shmulevich <[email protected]>
aixeshunter
approved these changes
Jun 10, 2019
|
Thanks for the cc. Reminder to myself to remove this from #5614 if this PR is merged first. |
csmarchbanks
approved these changes
Jun 11, 2019
|
Could this one be merged? cc @brian-brazil |
added 3 commits
June 13, 2019 09:04
Signed-off-by: Dmitry Shmulevich <[email protected]>
Signed-off-by: Dmitry Shmulevich <[email protected]>
Signed-off-by: Dmitry Shmulevich <[email protected]>
|
@brian-brazil addressed |
|
Thanks! |
jacksontj
pushed a commit
to jacksontj/prometheus
that referenced
this pull request
Jul 6, 2019
* resolve race condition in maxGauge Signed-off-by: Dmitry Shmulevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitry Shmulevich [email protected]