Promtool: Show the warnings during label query #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juliusv can you have a look at the PR? |
juliusv
reviewed
Aug 22, 2019
|
👍 besides the comment, thanks! |
sayanchowdhury
force-pushed
the
5885-show-promtool-warnings
branch
2 times, most recently
from
cd57eac
to
7d90432
Compare
This patch loops through the warnings while querying the label and spits the output to stderr Fixes prometheus#5885 Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
5885-show-promtool-warnings
branch
from
7d90432
to
463d78f
Compare
|
@juliusv i've updated the PR. |
|
👍 Thanks! |
krasi-georgiev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch loops through the warnings while querying the label and spits the
output to stderr.
Fixes #5885
Signed-off-by: Sayan Chowdhury [email protected]