Use strict unmarshalling of rules #7767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix prometheus#7042 Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
changed the title
|
This seems like a better approach, there's a test failure though. |
Signed-off-by: Julien Pivotto <[email protected]>
brian-brazil
reviewed
Aug 9, 2020
pkg/rulefmt/rulefmt.go
Outdated
| decoder := yaml.NewDecoder(bytes.NewReader(content)) | ||
| decoder.KnownFields(true) | ||
| err := decoder.Decode(&groups) | ||
| // Ignore io.EOF which happends with empty input. |
Signed-off-by: Julien Pivotto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7042
The problem is not only in promtool. Prometheus successfully load broken files now, which happened to me today. It loaded a rule file with annotation and not annotations.
The previous PR #7142 seems to have a larger scope, let's move on with this one and see what's left in #7142.
Signed-off-by: Julien Pivotto [email protected]