web: Remove APIv2 #7935
Merged
web: Remove APIv2 #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. |
Signed-off-by: Julien Pivotto <[email protected]>
| # google.golang.org/grpc v1.29.1 | ||
| ## explicit | ||
| google.golang.org/grpc |
There was a problem hiding this comment.
Is something else pulling this in now?
There was a problem hiding this comment.
Yes I figured out that it is now pulled by the protobuf stack.
|
https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis also needs updating. |
|
It seems like it will not solve cortex issues unless we block upgrading all the protobuf and google golang api's. |
|
It'll still resolve the cmux issue, and I imagine that Cortex isn't depending on GCE. |
Signed-off-by: Julien Pivotto <[email protected]>
|
👍 |
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Nov 3, 2020
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Nov 3, 2020
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Dec 1, 2020
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Feb 19, 2021
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Apr 9, 2021
This reverts commit e208afc.
mdanzinger
pushed a commit
to digitalocean/prometheus
that referenced
this pull request
May 27, 2021
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Aug 12, 2021
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Nov 5, 2021
This reverts commit e208afc.
bsnyder788
added a commit
to digitalocean/prometheus
that referenced
this pull request
Mar 29, 2022
This reverts commit e208afc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto [email protected]