Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: Expose total number of label pairs in head #8343

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

longngn
Copy link
Contributor

@longngn longngn commented Jan 5, 2021

Signed-off-by: Nguyen Le Vu Long [email protected]

Partially solves #7147

The metrics will be shown in the TSDB status page like this:
image

@longngn
Copy link
Contributor Author

longngn commented Jan 5, 2021

@codesome Could you take a look at this?

Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. I think this partially solves #7147 since we also wanted a metric for this.

tsdb/index/postings.go Outdated Show resolved Hide resolved
tsdb/index/postings.go Outdated Show resolved Hide resolved
Signed-off-by: Nguyen Le Vu Long <[email protected]>
tsdb/index/postings.go Outdated Show resolved Hide resolved
Signed-off-by: Nguyen Le Vu Long <[email protected]>
@codesome codesome merged commit cd1dafc into prometheus:master Jan 7, 2021
@codesome
Copy link
Member

codesome commented Jan 7, 2021

Thanks!

@longngn longngn deleted the fix-7147 branch January 7, 2021 07:14
fcddk pushed a commit to fcddk/prometheus that referenced this pull request Jan 26, 2021
…rometheus#8343)

* tsdb: Expose total number of label pairs in head

Signed-off-by: Nguyen Le Vu Long <[email protected]>

* fix: add comment for NumLabelPairs

Signed-off-by: Nguyen Le Vu Long <[email protected]>

* fix: remove comment

Signed-off-by: Nguyen Le Vu Long <[email protected]>
Signed-off-by: Dominic Yin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants