-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsdb: Expose total number of label pairs in head #8343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nguyen Le Vu Long <[email protected]>
@codesome Could you take a look at this? |
codesome
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits. I think this partially solves #7147 since we also wanted a metric for this.
Signed-off-by: Nguyen Le Vu Long <[email protected]>
codesome
reviewed
Jan 7, 2021
Signed-off-by: Nguyen Le Vu Long <[email protected]>
Thanks! |
fcddk
pushed a commit
to fcddk/prometheus
that referenced
this pull request
Jan 26, 2021
…rometheus#8343) * tsdb: Expose total number of label pairs in head Signed-off-by: Nguyen Le Vu Long <[email protected]> * fix: add comment for NumLabelPairs Signed-off-by: Nguyen Le Vu Long <[email protected]> * fix: remove comment Signed-off-by: Nguyen Le Vu Long <[email protected]> Signed-off-by: Dominic Yin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nguyen Le Vu Long [email protected]
Partially solves #7147
The metrics will be shown in the TSDB status page like this: