Allow users to specify prior process for row and column partitions #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BaxterEaves
commented
Mar 5, 2024
BaxterEaves
commented
- Dirichlet Process
- Pitman-Yor Process
added 6 commits
February 27, 2024 15:25
Got the view geweke tests passing for SAMS, Slice, and Gibbs using the Dirichlet process under the new PriorProcess abstraction. Lace still doesn't compile, but one thing at a time!
added 16 commits
March 5, 2024 15:37
Enumeration tests pass with PYP!
Still need - Metadata conversion tests - Pitman-Yor correctness tests
schmidmt
approved these changes
Mar 21, 2024
lace/lace_cc/src/misc.rs
Outdated
| } | ||
| } | ||
| } | ||
| // #[derive(Debug, Clone, Hash, PartialEq, Eq, Ord, PartialOrd)] |
There was a problem hiding this comment.
Should this just be removed?
added 9 commits
March 21, 2024 11:24
BaxterEaves
force-pushed
the
feature/pitman-yor
branch
from
6915863
to
39a51e2
Compare
BaxterEaves
force-pushed
the
feature/pitman-yor
branch
from
3218d1c
to
982c4d9
Compare
…rows based on index.
… an existing one fixup: Updated based on comments from @Swandog
fixup: Corrected formatting in the python module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.