-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stick breaking #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscherrer
commented
Apr 15, 2024
cscherrer
commented
Apr 15, 2024
BaxterEaves
requested changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thanks! Couple of minor comments!
BaxterEaves
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimental
module withstick_breaking_process
submodule containing:StickBreaking
struct representing a stick-breaking processStickBreakingDiscrete
struct representing a discrete distribution based on a stick-breaking processStickSequence
struct representing a sequence of stick breaksBreakSequence
struct representing a sequence of break pointsposterior
method onStickBreaking
to compute the posterior distribution given dataConjugatePrior
LnMCache
toMCache
LnPpCache
toPpCache
Rv
intoSampleable
andHasDensity
Process
generalizingRv
Parameterized
traitimpl<X: Booleable> ConjugatePrior<X, Bernoulli> for UnitPowerLaw
ConvergentSequence
implementing Aitken's delta-squared methodsorted_uniforms
helper function