Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Gemfile and .gemspecs as Ruby #344

Merged

Conversation

sunny
Copy link
Contributor

@sunny sunny commented May 14, 2019

This allows pronto-rubocop (and others) to treat the common Gemfile and *.gemspec files as Ruby.

Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @prontolabs/core any thoughts before merging this?

spec/pronto/runner_spec.rb Outdated Show resolved Hide resolved
@doomspork
Copy link
Member

Thank you @sunny 😁

@doomspork doomspork merged commit e2f4440 into prontolabs:master May 16, 2019
@sunny
Copy link
Contributor Author

sunny commented May 16, 2019

Thank you for the swift merge and for helping maintain pronto \o/

@sunny sunny deleted the treat-gemfiles-and-gemspecs-as-ruby branch May 16, 2019 14:12
@doomspork
Copy link
Member

You're very welcome @sunny! I want to get a few of the other outstanding PRs merged and then cut a new release. If you're interested in lending a hand, I would greatly appreciate it 😁I'd love to grow the team of contributors

apiology pushed a commit to apiology/pronto that referenced this pull request Dec 27, 2019
* Treat Gemfile and .gemspecs as Ruby

* Fix path of Gemfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants